Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support swift-corelibs-libdispatch #5565

Open
kateinoigakukun opened this issue Feb 5, 2024 · 4 comments
Open

Support swift-corelibs-libdispatch #5565

kateinoigakukun opened this issue Feb 5, 2024 · 4 comments

Comments

@kateinoigakukun
Copy link
Member

We will be able to support it after #5548

@kateinoigakukun kateinoigakukun changed the title swift-corelibs-libdispatch Support Support swift-corelibs-libdispatch Feb 5, 2024
@Kyle-Ye
Copy link

Kyle-Ye commented Feb 24, 2024

Running into dispatch compiler issue recently. Looks like dispatch is currently not supported on WASM.

In file included from /home/runner/work/OpenGraph/OpenGraph/Sources/_OpenGraph/Graph/Graph.cpp:9:
In file included from /opt/hostedtoolcache/swiftwasm/wasm-5.9.1-RELEASE/x86_64/usr/lib/swift_static/dispatch/dispatch.h:64:
/opt/hostedtoolcache/swiftwasm/wasm-5.9.1-RELEASE/x86_64/usr/lib/swift_static/os/object.h:221:1: error: unknown type name '__BEGIN_DECLS'
__BEGIN_DECLS

@Kyle-Ye
Copy link

Kyle-Ye commented Feb 24, 2024

Does it mean #if defined(__unix__) is not evaluated to true for WASI and we need to a PR to fix it here?

https://github.com/apple/swift-corelibs-libdispatch/blob/5529d351e304eb2312b7b3bfb073f7d8285473e0/os/object.h#L24-L33

@kateinoigakukun
Copy link
Member Author

libdispatch is not supported yet at all

@Kyle-Ye
Copy link

Kyle-Ye commented Feb 24, 2024

libdispatch is not supported yet at all

Got it. I'll use macro to disable it for WASI platform.

https://github.com/OpenSwiftUIProject/OpenGraph/blob/d35513b213be037fe97995b1704020b837a4a9e8/Sources/_OpenGraph/Graph/Graph.cpp#L21-L29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To triage
Development

No branches or pull requests

2 participants