Skip to content

Work around Windows build failure due to SwiftPM regression. #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 11, 2024
Merged

Work around Windows build failure due to SwiftPM regression. #816

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b03288b
Work around Windows build failure due to SwiftPM regression.
grynspan Nov 11, 2024
071c975
Revert "Work around Windows build failure due to SwiftPM regression."
grynspan Nov 11, 2024
989ab32
Try a different workaround
grynspan Nov 11, 2024
6a2ad66
Fix typo
grynspan Nov 11, 2024
e7111a5
Disable module lookup, let's see if that helps
grynspan Nov 11, 2024
bc48d6f
Revert "Disable module lookup, let's see if that helps"
grynspan Nov 11, 2024
df6ca31
Revert "Fix typo"
grynspan Nov 11, 2024
99092c4
Revert "Try a different workaround"
grynspan Nov 11, 2024
df168b5
Try just making the library target dynamic
grynspan Nov 11, 2024
861ba92
Revert "Try just making the library target dynamic"
grynspan Nov 11, 2024
0c10340
Just disable the failing test until SwiftPM is fixed
grynspan Nov 11, 2024
339ff20
Facepalm emoji
grynspan Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Tests/TestingTests/ABIEntryPointTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ struct ABIEntryPointTests {
passing arguments: __CommandLineArguments_v0,
recordHandler: @escaping @Sendable (_ recordJSON: UnsafeRawBufferPointer) -> Void = { _ in }
) async throws -> Bool {
#if !(!SWT_FIXED_SWIFTPM_8111 && os(Windows))
#if !os(Linux) && !os(FreeBSD) && !os(Android) && !SWT_NO_DYNAMIC_LINKING
// Get the ABI entry point by dynamically looking it up at runtime.
//
Expand All @@ -142,6 +143,7 @@ struct ABIEntryPointTests {
}
)
}
#endif
#endif
let abiEntryPoint = unsafeBitCast(abiv0_getEntryPoint(), to: ABIv0.EntryPoint.self)

Expand Down