Skip to content

Add additional canImport checks to AttachmentTests.swift #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2025
Merged

Add additional canImport checks to AttachmentTests.swift #1244

merged 1 commit into from
Jul 29, 2025

Conversation

@grynspan
Copy link
Contributor

@grynspan grynspan commented Jul 29, 2025 •
edited
Loading

This PR adds more canImport checks to AttachmentTests so that, if we're not building e.g. _Testing_AppKit, the file still compiles.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Add additional canImport checks to AttachmentTests.swift
0e2c538 
This PR adds more `canImport` checks to `AttachmentTests` so that, if we're not
building e.g. `_Testing_AppKit`, the file still compiles.
@grynspan grynspan added this to the Swift 6.x (main) milestone Jul 29, 2025
@grynspan grynspan self-assigned this Jul 29, 2025
@grynspan grynspan added the bug 🪲 Something isn't working label Jul 29, 2025
@grynspan grynspan requested a review from stmontgomery as a code owner July 29, 2025 17:46
@grynspan grynspan added the darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support label Jul 29, 2025
@grynspan grynspan added build 🧱 Affects the project's build configuration or process attachments/activities 🖇️ Work related to attachments and/or activities cross-import-overlays 🍰 Cross-import overlays (Foundation, Core Graphics, etc.) labels Jul 29, 2025
@grynspan
Copy link
Contributor Author

grynspan commented Jul 29, 2025

@swift-ci test

@grynspan grynspan merged commit 8502f73 into main Jul 29, 2025
3 checks passed
@grynspan grynspan deleted the jgrynspan/attachment-test-overlay-canImport-fixes branch July 29, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@briancroom briancroom briancroom approved these changes

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff

Assignees

@grynspan grynspan

Labels

attachments/activities 🖇️ Work related to attachments and/or activities bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process cross-import-overlays 🍰 Cross-import overlays (Foundation, Core Graphics, etc.) darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support

Projects

None yet

Milestone

Swift 6.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@grynspan @stmontgomery @briancroom