Merge pull request #793 from tshortli/revert-770

Author: beccadax

Sources/Testing/ABI/EntryPoints/EntryPoint.swift

@@ -275,9 +275,6 @@ public struct __CommandLineArguments_v0: Sendable {
 
   /// The value of the `--repeat-until` argument.
   public var repeatUntil: String?
-
-  /// The value of the `--experimental-attachments-path` argument.
-  public var experimentalAttachmentsPath: String?
 }
 
 extension __CommandLineArguments_v0: Codable {
@@ -298,7 +295,6 @@ extension __CommandLineArguments_v0: Codable {
     case skip
     case repetitions
     case repeatUntil
-    case experimentalAttachmentsPath
   }
 }
 
@@ -359,11 +355,6 @@ func parseCommandLineArguments(from args: [String]) throws -> __CommandLineArgum
   if let xunitOutputIndex = args.firstIndex(of: "--xunit-output"), !isLastArgument(at: xunitOutputIndex) {
     result.xunitOutput = args[args.index(after: xunitOutputIndex)]
   }
-
-  // Attachment output
-  if let attachmentsPathIndex = args.firstIndex(of: "--experimental-attachments-path"), !isLastArgument(at: attachmentsPathIndex) {
-    result.experimentalAttachmentsPath = args[args.index(after: attachmentsPathIndex)]
-  }
 #endif
 
   if args.contains("--list-tests") {
@@ -473,14 +464,6 @@ public func configurationForEntryPoint(from args: __CommandLineArguments_v0) thr
     }
   }
 
-  // Attachment output.
-  if let attachmentsPath = args.experimentalAttachmentsPath {
-    guard fileExists(atPath: attachmentsPath) else {
-      throw _EntryPointError.invalidArgument("--experimental-attachments-path", value: attachmentsPath)
-    }
-    configuration.attachmentsPath = attachmentsPath
-  }
-
 #if canImport(Foundation)
   // Event stream output (experimental)
   if let eventStreamOutputPath = args.eventStreamOutputPath {

Sources/Testing/ABI/v0/Encoded/ABIv0.EncodedAttachment.swift

@@ -27,7 +27,6 @@ extension ABIv0 {
       case testStarted
       case testCaseStarted
       case issueRecorded
-      case valueAttached = "_valueAttached"
       case testCaseEnded
       case testEnded
       case testSkipped
@@ -46,14 +45,6 @@ extension ABIv0 {
     /// ``kind-swift.property`` property is ``Kind-swift.enum/issueRecorded``.
     var issue: EncodedIssue?
 
-    /// The value that was attached, if any.
-    ///
-    /// The value of this property is `nil` unless the value of the
-    /// ``kind-swift.property`` property is ``Kind-swift.enum/valueAttached``.
-    ///
-    /// - Warning: Attachments are not yet part of the JSON schema.
-    var _attachment: EncodedAttachment?
-
     /// Human-readable messages associated with this event that can be presented
     /// to the user.
     var messages: [EncodedMessage]
@@ -80,9 +71,6 @@ extension ABIv0 {
       case let .issueRecorded(recordedIssue):
         kind = .issueRecorded
         issue = EncodedIssue(encoding: recordedIssue, in: eventContext)
-      case let .valueAttached(attachment):
-        kind = .valueAttached
-        _attachment = EncodedAttachment(encoding: attachment, in: eventContext)
       case .testCaseEnded:
         if eventContext.test?.isParameterized == false {
           return nil

Sources/Testing/ABI/v0/Encoded/ABIv0.EncodedEvent.swift

@@ -30,7 +30,6 @@ extension ABIv0 {
       case difference
       case warning
       case details
-      case attachment = "_attachment"
 
       init(encoding symbol: Event.Symbol) {
         self = switch symbol {
@@ -52,8 +51,6 @@ extension ABIv0 {
           .warning
         case .details:
           .details
-        case .attachment:
-          .attachment
         }
       }
     }