Update unit tests to align the convention and update release noten

Finetune the code

Update release note

Author: joehsieh

Release Notes/511.md

@@ -1,6 +1,15 @@
 # Swift Syntax 511 Release Notes
 
 ## New APIs
+- FixIt now has a new computed propery named edits
+  - Description: the edits represent the non-overlapping textual edits that need to be performed when the Fix-It is applied.
+  - Issue: https://github.com/apple/sourcekit-lsp/issues/909
+  - Pull Request: https://github.com/apple/swift-syntax/pull/2314
+
+- SourceEdit
+  - Description: SourceEdit has been moved from SwiftRefactor to SwiftSyntax
+  - Issue: https://github.com/apple/sourcekit-lsp/issues/909
+  - Pull Request: https://github.com/apple/swift-syntax/pull/2314
 
 ## API Behavior Changes
 

Sources/SwiftDiagnostics/FixIt.swift

@@ -47,11 +47,12 @@ public struct FixIt {
   }
 }
 
-public extension FixIt {
-  var edits: [SourceEdit] {
+extension FixIt {
+  /// The edits represent the non-overlapping textual edits that need to be performed when the Fix-It is applied.
+  public var edits: [SourceEdit] {
     var existingEdits = [SourceEdit]()
     for change in changes {
-      let edit = SourceEdit.edit(from: change)
+      let edit = change.edit
       let isOverlapping = existingEdits.contains { edit.range.overlaps($0.range) }
       if !isOverlapping {
         // The edit overlaps with the previous edit. We can't apply both
@@ -64,9 +65,9 @@ public extension FixIt {
   }
 }
 
-private extension SourceEdit {
-  static func edit(from change: FixIt.Change) -> SourceEdit {
-    switch change {
+private extension FixIt.Change {
+  var edit: SourceEdit {
+    switch self {
       case .replace(let oldNode, let newNode):
         return SourceEdit(
           range: oldNode.position..<oldNode.endPosition,

Tests/SwiftDiagnosticsTest/FixItTests.swift

@@ -18,14 +18,14 @@ import _SwiftSyntaxTestSupport
 
 final class FixItTests: XCTestCase {
   func testEditsForFixIt() throws {
-    let markedSource = "protocol 0️⃣Multi 1️⃣ident 2️⃣{}"
+    let markedSource = "protocol 1️⃣Multi 2️⃣ident 3️⃣{}"
     let (markers, source) = extractMarkers(markedSource)
-    let positions = ["0️⃣", "1️⃣", "2️⃣"].compactMap { markers[$0] }
+    let positions = markers.mapValues { AbsolutePosition(utf8Offset: $0) }
     XCTAssertEqual(positions.count, 3)
 
     let expectedEdits = [
-      SourceEdit(range: AbsolutePosition(utf8Offset: positions[0]) ..< AbsolutePosition(utf8Offset: positions[1]), replacement: "Multiident "),
-      SourceEdit(range: AbsolutePosition(utf8Offset: positions[1]) ..< AbsolutePosition(utf8Offset: positions[2]), replacement: "")
+      SourceEdit(range: positions["1️⃣"]! ..< positions["2️⃣"]!, replacement: "Multiident "),
+      SourceEdit(range: positions["2️⃣"]! ..< positions["3️⃣"]!, replacement: "")
     ]
     let tree = Parser.parse(source: source)
     let diags = ParseDiagnosticsGenerator.diagnostics(for: tree)