[NFC] Update .swiftformat config for consistency
#6122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
requested review from
abertelrud,
elsh,
neonichu and
tomerd
as code owners
tomerd
approved these changes
Feb 6, 2023
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci smoke test macOS |
Contributor
Author
|
@swift-ci test Windows |
Contributor
Author
|
Windows failure in llbuild looks unrelated to me. |
tomerd
pushed a commit
to tomerd/swift-package-manager
that referenced
this pull request
Feb 7, 2023
`UserToolchain.swift` was formatted by `swift-format` with a config that's inconsistent with `.swiftformat` committed in the repository, primarily in its use of 2-space indentation. Reverted the commit that applies `swift-format`. Also updated `.swiftformat` with more tweaks that codify conventions already established in our repository. Applied new rules to `UserToolchain.swift`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
UserToolchain.swiftwas formatted byswift-formatwith a config that's inconsistent with.swiftformatcommitted in the repository, primarily in its use of 2-space indentation.Modifications:
Reverted the commit that applies
swift-format. Also updated.swiftformatwith more tweaks that codify conventions already established in our repository. Applied new rules toUserToolchain.swiftResult:
Automated formatting in
UserToolchain.swiftis applied.