Prevent null character in Windows home directory #808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
compnerd
approved these changes
Jul 31, 2024
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Ah, the W terminator is \0\0. Nice catch!
Member
|
@jrflat anything left to do here, or good to merge? |
Contributor
Author
|
Will merge soon after some testing on Darwin |
jrflat
added a commit
to jrflat/swift-foundation
that referenced
this pull request
Aug 2, 2024
jrflat
added a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #807
String(decoding:as:)was including the null-terminator from the Windows API, and when this is passed toURL, it's encoded in the formfile:///C:/Users/alex%00/. When enumerating the directory, we get the file system representation of theURL, which decodes%00to back to\0. This was causing us to append a file namealexto the directory, gettingfile:///C:/Users/alex%00/alex, which "exists" because it was only checking for the existence offile:///C:/Users/alex. This cycle repeats, causing an infinite loop in the enumerator.This PR 1) replaces
String(decoding:as:)withString(decodingCString:as:)in the home directory function and 2) preventsURL.fileSystemPathfrom decoding%00to\0.