From 3bd45820b50322f25b6a273dbbcf996bd2808f4a Mon Sep 17 00:00:00 2001 From: Alex Hoppen Date: Wed, 5 Mar 2025 10:31:36 -0800 Subject: [PATCH] Run Windows tests inside a Docker container Looks like GitHub updated Visual Studio on their Windows runners and the new SDK causes compilation issues. Run in a Docker container so we fully control the version of Visual Studio installed. --- .github/workflows/publish_release.yml | 1 - .github/workflows/pull_request.yml | 2 -- 2 files changed, 3 deletions(-) diff --git a/.github/workflows/publish_release.yml b/.github/workflows/publish_release.yml index 5c1985c7c..a360c3f97 100644 --- a/.github/workflows/publish_release.yml +++ b/.github/workflows/publish_release.yml @@ -99,7 +99,6 @@ jobs: matrix: release: [true, false] with: - enable_windows_docker: false # Dockerless Windows is 5-10 minutes faster than Docker on Windows linux_pre_build_command: | git config --global --add safe.directory "$(realpath .)" git config --local user.name 'swift-ci' diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index b29107802..87e2293aa 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -8,8 +8,6 @@ jobs: tests: name: Test uses: swiftlang/github-workflows/.github/workflows/swift_package_test.yml@main - with: - enable_windows_docker: false # Dockerless Windows is 5-10 minutes faster than Docker on Windows soundness: name: Soundness uses: swiftlang/github-workflows/.github/workflows/soundness.yml@main