Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows builds broken when querying target-info from libSwiftScan #1341

Closed
artemcm opened this issue Apr 28, 2023 · 2 comments
Closed

Windows builds broken when querying target-info from libSwiftScan #1341

artemcm opened this issue Apr 28, 2023 · 2 comments
Assignees
@artemcm

Comments

@artemcm
Copy link
Contributor

artemcm commented Apr 28, 2023

After such queries result in target-infos containing double-quoted paths, e.g.:

    "sdkPath" : "'C:\\Library\\Developer\\Platforms\\Windows.platform\\Developer\\SDKs\\Windows.sdk'"

This failure is caused by #1335. For now we will disable libSwiftScan target info query on Windows while we understand how to get the paths right here.
@artemcm artemcm self-assigned this Apr 28, 2023
@artemcm artemcm mentioned this issue Apr 28, 2023
Closed
@artemcm
Copy link
Contributor Author

artemcm commented Apr 28, 2023

The solution here will be to quote paths properly on Windows in the ArgsResolver:
https://github.com/apple/swift-driver/blob/3f1598182844954898239e8a2528a5e761b2110c/Sources/SwiftDriver/Execution/ArgsResolver.swift#L119

Because simply using ' is not correct. We should probably piggy-back on @compnerd's work here:
https://github.com/apple/swift-driver/blob/4f3d37f411f2eb6634b4985a4d3452a527637ad5/Sources/SwiftDriver/Utilities/System.swift#L58

@artemcm
Copy link
Contributor Author

artemcm commented May 3, 2023

Resolved with #1343

@artemcm artemcm closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artemcm artemcm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@artemcm