Generalize the removal of compiler argument options during indexing #1314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci Please test |
Merged
hamishknight
approved these changes
May 17, 2024
bnbarham
reviewed
May 17, 2024
bnbarham
approved these changes
May 17, 2024
The existing ad-hoc logic was not quite correct because it didn’t eg. remove `-MT/depfile` because it assumed that `-MT` was followed by a space. It also didn’t take into account that `serialize-diagnostics` can be spelled with a single dash or two dashes. Create a `CompilerCommandLineOption` type that forces decisions to be made about the dash spelling and argument styles, which should help avoid problems like this in the future.
ahoppen
force-pushed
the
command-line-sanitization
branch
from
cd33fbf to
5bad2c5
Compare
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test Windows |
2 similar comments
Member
Author
|
@swift-ci Please test Windows |
Member
Author
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing ad-hoc logic was not quite correct because it didn’t eg. remove
-MT/depfilebecause it assumed that-MTwas followed by a space. It also didn’t take into account thatserialize-diagnosticscan be spelled with a single dash or two dashes.Create a
CompilerCommandLineOptiontype that forces decisions to be made about the dash spelling and argument styles, which should help avoid problems like this in the future.