Skip to content

Commit 082fca2

Browse files
committed
Remove "--target NIOCore" from Android CI in main.yml
1 parent 41ffac1 commit 082fca2

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

.github/workflows/main.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,6 @@ jobs:
7575
name: Android Swift SDK
7676
# Workaround https://github.com/nektos/act/issues/1875
7777
uses: apple/swift-nio/.github/workflows/android_sdk.yml@main
78-
with:
79-
additional_command_arguments: "--target NIOCore"
8078

8179
macos-tests:
8280
name: macOS tests

scripts/install_swift_sdk.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ swift sdk install "$sdk_path"
132132
log "Swift SDK Post-install"
133133
if [[ "$sdk" == "android-sdk" ]]; then
134134
# guess some common places where the swift-sdks folder lives
135-
cd ~/Library/org.swift.swiftpm || cd ~/.config/swiftpm || cd ~/.local/swiftpm || cd ~/.swiftpm || cd /root/.swiftpm || exit 1
135+
cd ~/Library/org.swift.swiftpm || cd ~/.config/swiftpm || cd ~/.local/swiftpm || cd ~/.swiftpm || cd /root/.swiftpm || fatal "Cannot locate swiftpm config directory"
136136

137137
# download and link the NDK
138138
android_ndk_url="https://dl.google.com/android/repository/android-ndk-${android_ndk_version}-$(uname -s).zip"
@@ -143,5 +143,5 @@ if [[ "$sdk" == "android-sdk" ]]; then
143143
export ANDROID_NDK_HOME="${PWD}/android-ndk-${android_ndk_version}"
144144
bundledir=$(find . -type d -maxdepth 2 -name '*android*.artifactbundle' | head -n 1)
145145
"${bundledir}"/swift-android/scripts/setup-android-sdk.sh
146-
cd - || exit
146+
cd - || fatal "Cannot cd back to previous directory"
147147
fi

0 commit comments

Comments
 (0)