Merge pull request #406 from ytkg/patch-4

refactor: 早期リターンするようにした

Author: swfz

pages/kusa/[user].tsx

@@ -16,26 +16,22 @@ export const getServerSideProps = async (
 ): Promise<GetServerSidePropsResult<Props>> => {
   const user = context.params?.user;
 
-  if (typeof user === 'string') {
-    const res = await fetch(`https://github-contributions-api.deno.dev/${user}.json`);
-    const json = await res.json();
+  if (typeof user !== 'string') {
+    return { notFound: true };
+  }
 
-    const contributions = json.contributions
-      .flat()
-      .reverse()
-      .map((c: { contributionCount: number }) => c.contributionCount);
+  const res = await fetch(`https://github-contributions-api.deno.dev/${user}.json`);
+  const json = await res.json();
 
-    const [todayContributionCount, yesterdayContributionCount] = contributions;
-    const currentStreak = todayContributionCount > 0 ? contributions.indexOf(0) : contributions.slice(1).indexOf(0);
+  const contributions = json.contributions
+    .flat()
+    .reverse()
+    .map((c: { contributionCount: number }) => c.contributionCount);
 
-    return {
-      props: { user, todayContributionCount, yesterdayContributionCount, currentStreak },
-    };
-  } else {
-    return {
-      notFound: true,
-    };
-  }
+  const [todayContributionCount, yesterdayContributionCount] = contributions;
+  const currentStreak = todayContributionCount > 0 ? contributions.indexOf(0) : contributions.slice(1).indexOf(0);
+
+  return { props: { user, todayContributionCount, yesterdayContributionCount, currentStreak } };
 };
 
 const fetchFunc = async (userId: string) => {