refactor: merged jars #114
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladasZ
reviewed
Nov 27, 2024
VladasZ
reviewed
Nov 27, 2024
| self.score = AccountScore::new(timezone); | ||
| } | ||
| (None, false) => { | ||
| panic_str("Trying to create score based jar for without providing time zone"); |
There was a problem hiding this comment.
Suggested change
| panic_str("Trying to create score based jar for without providing time zone"); | |
| panic_str("Trying to create score based jar without providing time zone"); |
VladasZ
reviewed
Nov 27, 2024
VladasZ
reviewed
Nov 27, 2024
VladasZ
approved these changes
Nov 28, 2024
contract/src/jar/model/v2.rs
Outdated
| pub struct JarV2 { | ||
| pub deposits: Vec<Deposit>, | ||
| pub cache: Option<JarCache>, | ||
| // TODO: get rid of it |
There was a problem hiding this comment.
Will you do it in this PR?
| /// Describes additional terms for Flexible products. | ||
| Flexible(FlexibleProductTerms), | ||
|
|
||
| /// TODO: doc |
contract/src/jar/model/v2.rs
Outdated
| self | ||
| } | ||
|
|
||
| pub(crate) fn try_lock(&mut self) -> &mut Self { |
There was a problem hiding this comment.
In which cases we use lock and in which try_lock?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.