Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable names for temperatures could be made consistent #1052

Open
edbennett opened this issue Jul 20, 2023 · 0 comments
Open

Variable names for temperatures could be made consistent #1052

edbennett opened this issue Jul 20, 2023 · 0 comments
Labels
type:enhancement Propose enhancement to the lesson

Comments

@edbennett
Copy link
Contributor

edbennett commented Jul 20, 2023

Currently four conventions are used for variable names for temperatures in episode 08:

  • fahrenheit_val and celsius_val (with or without a suffix)
  • temp, with no qualification
  • temp_c, temp_f, and temp_k
  • temp_fahr and temp_kelvin

Is there a reason not to use a single, consistent way of spelling these?

(In particular, temp with no qualifier makes an assumption of Fahrenheit as the default, which is not true outside of North America; see my comment on #1000.)

@AlbertoImg AlbertoImg added the type:enhancement Propose enhancement to the lesson label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Propose enhancement to the lesson
Projects
None yet
Development

No branches or pull requests

2 participants