sway crashes if switch to another workspace with surface when IME popup is shown

[OkamiW]

• Sway Version:
  sway version 1.10-dev-c90cb37b (Oct 6 2024, branch 'master')

• Stack Trace:

#0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at pthread_kill.c:44
#1   in __pthread_kill_internal (threadid=<optimized out>, signo=6) at pthread_kill.c:78
#2   in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#3   in __GI_abort () at abort.c:79
#4   in __assert_fail_base (fmt= "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry= "node", file=file@entry= "types/scene/wlr_scene.c", line=line@entry=1214, 
    function=function@entry= <__PRETTY_FUNCTION__.5> "wlr_scene_node_coords") at assert.c:94
#5   in __assert_fail (assertion= "node", file= "types/scene/wlr_scene.c", line=1214, function= <__PRETTY_FUNCTION__.5> "wlr_scene_node_coords") at assert.c:103
#6   in wlr_scene_node_coords (node=, lx_ptr=, ly_ptr=) at ../subprojects/wlroots/types/scene/wlr_scene.c:1214
#7   in arrange_popups (popups=) at ../sway/desktop/transaction.c:617
#8   in arrange_root (root=) at ../sway/desktop/transaction.c:687
#9   in transaction_progress () at ../sway/desktop/transaction.c:741
#10  in transaction_commit_pending () at ../sway/desktop/transaction.c:861
#11  in _transaction_commit_dirty (server_request=true) at ../sway/desktop/transaction.c:937
#12  in transaction_commit_dirty () at ../sway/desktop/transaction.c:941
#13  in seat_execute_command (seat=, binding=) at ../sway/commands/bind.c:648
#14  in handle_key_event (keyboard=, event=) at ../sway/input/keyboard.c:489
#15  in handle_keyboard_group_key (listener=, data=) at ../sway/input/keyboard.c:561
#16  in wl_signal_emit_mutable (signal=<optimized out>, data=) at ../wayland-1.23.1/src/wayland-server.c:2314
#17  in wlr_keyboard_notify_key (keyboard=, event=) at ../subprojects/wlroots/types/wlr_keyboard.c:102
#18  in handle_keyboard_key (listener=, data=) at ../subprojects/wlroots/types/wlr_keyboard_group.c:111
#19  in wl_signal_emit_mutable (signal=<optimized out>, data=) at ../wayland-1.23.1/src/wayland-server.c:2314
#20  in wlr_keyboard_notify_key (keyboard=, event=) at ../subprojects/wlroots/types/wlr_keyboard.c:102
#21  in handle_keyboard_key (event=, kb=) at ../subprojects/wlroots/backend/libinput/keyboard.c:50
#22  in handle_libinput_event (backend=, event=) at ../subprojects/wlroots/backend/libinput/events.c:158
#23  in handle_libinput_readable (fd=46, mask=1, _backend=) at ../subprojects/wlroots/backend/libinput/backend.c:59
#24  in wl_event_loop_dispatch (loop=, timeout=<optimized out>, timeout@entry=-1) at ../wayland-1.23.1/src/event-loop.c:1105
#25  in wl_display_run (display=) at ../wayland-1.23.1/src/wayland-server.c:1530
#26  in server_run (server= <server>) at ../sway/server.c:506
#27  in main (argc=2, argv=) at ../sway/main.c:373

[emersion]

cc @Nefsen402, seems related to your IME popup rework?

[layercak3]

Yeah, this started happening after that PR was merged. IIRC it can be reproduced by switching focus between two floating foot windows. I have fcitx5 with 'show input method when focus changed' enabled.

[Decodetalkers]

https://github.com/swaywm/sway/pull/8196/files#diff-58653e4a25a6380a65e2c8a3e3c39ec5a56d3c1f93d5ac53591e47bd2ad6203cR458

problem is from here I think. then the surface is unmap, the relative is set to NULL, but it still be in popups