floating mpv window flickers and changes position when resizing

[llyyr]

• Sway Version:
  • sway git

Video: https://0x0.st/HiBi.mp4

How to reproduce: start mpv with --no-config as a floating window, and try to resize to 0x0 or like in the video

Original issue here mpv-player/mpv#11435

The mpv window does nothing besides try to keep the aspect ratio when resizing, I don't know of any other client that wants to do that so I can't say if it's just mpv or any application that wants to keep a certain aspect ratio...

wayland_debug.log

[anpandey]

Resizing a floating mpv horizontally, the height seems to briefly jump to what it's supposed to be:

[1044195.253]  -> [email protected]_configure(40006)
[1044209.143] [email protected](433, 670, array[8])
[1044209.149] [email protected](40007)
[1044209.151]  -> [email protected]_configure(40007)
[1044409.391] [email protected](422, 670, array[8])
[1044409.428] [email protected](40008)
[1044409.436]  -> [email protected]_configure(40008)
[1044414.098] [email protected](422, 317, array[8])  <-----
[1044414.107] [email protected](40009)
[1044414.111]  -> [email protected]_configure(40009)
[1044416.822] [email protected](421, 670, array[8])
[1044416.830] [email protected](40010)
[1044416.834]  -> [email protected]_configure(40010)
[1044423.580] [email protected](421, 670, array[8])
[1044423.585] [email protected](40011)

Could be related to #5266. However, it doesn't look like mpv uses set_window_geometry.

[anpandey]

The same problem is mentioned in #7195 (comment). sway ends up setting the size in two different places:

• handle_pointer_motion commits the new size of the container based on the position of the pointer. However, it only uses the size of the container when the resize op began (and ignores any enforcement of aspect ratio mpv might be doing)
• As a consequence the commit handler detects the updated size, and creates a new transaction with the proper size based on the surface even though the first transaction hasn't been applied yet.

[uncomfyhalomacro]

Seems to be a wlroots issue. since it also affects riverwm

[llyyr]

No, it's a sway/river issue and it's fixed on river already but the fix is unreleased riverwm/river@9db4111

[uncomfyhalomacro]

No, it's a sway/river issue and it's fixed on river already but the fix is unreleased riverwm/river@9db4111

I will check if i have the patch put on opensuse factory. 🤔

[uncomfyhalomacro]

No, it's a sway/river issue and it's fixed on river already but the fix is unreleased riverwm/river@9db4111

tested it. it's neither a wlroots issue nor a wayland issue (it can be) since it also happens in GNOME or KDE Plasma Wayland

[llyyr]

It doesn't happen in river patched with that commit, or on Weston (according to upstream issue), or on KDE/Gnome. Are you sure you're experiencing the same issue?

[uncomfyhalomacro]

It doesn't happen in river patched with that commit, or on Weston (according to upstream issue), or on KDE/Gnome. Are you sure you're experiencing the same issue?

Nvm it was another issue. It's this one mpv-player/mpv#11420. i read this issue wrong

[llyyr]

Partially fixed by #8295 and the corresponding wlroots change, now the SSD (borders) is always correct at least. The window however still flickers while you're resizing and can change position.