0.14 #1237

ddevault · 2017-06-14T23:04:16Z

Let's start getting 0.14 out the door.

https://github.com/SirCmpwn/sway/releases/tag/0.14-rc1

Will prepare a changelog later tonight.

ddevault · 2017-06-15T00:54:32Z

Changelog:

This is a relatively small release with 53 changes from 12 contributors. New features include support for tray icons and support for KDE's Wayland extension for client-side border negotiation. Several smaller features and many bug fixes are also included. Updates to wlc also improve touchscreen support and fix the old extra cursor gdm issue.

Tray icons are now supported via SNI, and Xembed support is in-progress and planned for a future release. Tray icons for programs using the new specification should work correctly, but older programs using Xembed will not. Border negotiation requries participation from the client - a patch for GTK+ is available here. Reminder to self: update wiki page on removing GTK borders

You may have heard that we're replacing wlc, a library that does a lot of low-level plumbing work for Sway. I'm happy to announce that our replacement project, wlroots, is progressing at a great pace - largely thanks to financial support from Nyantec, who offered to sponsor me to work full time on Sway for a while. Additional support has come from supporters of my new Patreon page - many thanks! Dramatic improvements to Sway will be possible when wlroots is ready. Look forward to it!

Changes

libdbus is now an optional dependency for tray icon support (package maintainers, take note)
Non-logind systems now report configuration errors more verbosely (@Hummer12007 - Terminate when both suid bit and filecaps are set #1218)
asciidoc is now optional; without it man pages will not be built (@SirCmpwn - cf4ea4c)

New Features

SNI tray icon support in swaybar (@4e554c4c - Implement Tray Icons #1234)
KDE's server decorations protocol is now supported (@SirCmpwn - Implement KDE's server-side decoration protocol #1199)
Mouse button bindings (@janza - Add mouse button bindings #1209)
i3's no_focus command is now supported (@SirCmpwn - Implement no_focus #1196)

Bugs fixed

Specifying fewer than 5 colors during configuration did not work (@SirCmpwn - Support specifying fewer than 5 colors #1201)
layout auto with no additional arguments no longer crashes Sway (@zandrmartin - prevent crash when layout auto is missing args #1204)
Issues with the Firefox address bar dropdown have been fixed (@SirCmpwn - d158e18)
Nested child processes of swaybar are now killed correctly (@ykrivopalov - swaybar: Group child processes for signalling #1236)
Minor documentation fixes via @4e554c4c, @zandrmartin, @wdbw, @her001
@johalun fixed some FreeBSD issues and is now the FreeBSD point of contact (FreeBSD fixes #1232)
Use-after-free bug fixed in bindsym (@tobiasblass - fix use-after-free bug #1270)
Fail gracefully when security policies cannot be allocated (@Hummer12007 - Prevent null pointer dereferences with policy allocation failure #1255)

WhyNotHugo · 2017-06-15T01:02:43Z

Tray icons are now supported via SNI, and Xembed

Aren't AppIndicator designed explicitly not to rely on Xorg-specifics? Maybe that's a slightly cleaner target for wayland?
The big downside is that there's very little/poor documentation. :(

Oh, and thanks for all the hard work and to Nyantec for sponsoring this too! 🎉

ddevault · 2017-06-15T01:04:48Z

Some proof of concept work has been done with Xembed - it definitely works, it just requires some finageling. I don't really know much about AppIndicator.

4e554c4c · 2017-06-15T01:20:20Z

Is appindicator server side? I only see client side bindings. I think it's best to continue to use what we have already, and if it needs expansion for appindicators that can happen.

soredake · 2017-06-15T18:12:55Z

appindicators

I really want this for https://github.com/Bajoja/indicator-kdeconnect

4e554c4c · 2017-06-15T18:35:18Z

Does it not work with this rc? That project's readme says it uses StatusNotifierItem.

soredake · 2017-06-15T19:45:38Z

@4e554c4c KStatusNotifierItem is kde only, not working on latest master.

ddevault · 2017-06-23T00:23:51Z

0.14-rc2

Contains only documentation fixes, but I'd still like testing to continue for another week at the least.

ddevault · 2017-06-29T17:20:22Z

0.14-rc3 is out. Contains 3 bug fixes. Please test.

johalun · 2017-07-07T09:50:23Z

0.14-rc3 unmodified on FreeBSD12-CURRENT with clang 4.0.0
Will investigate further after lunch.

[ 96%] Building C object swaybar/CMakeFiles/swaybar.dir/event_loop.c.o
/home/johannes/dev/sway/swaybar/event_loop.c:99:24: error: comparison of distinct pointer types ('timer_t' (aka 'struct __timer *') and
      'const timer_t *' (aka 'struct __timer *const *')) [-Werror,-Wcompare-distinct-pointer-types]
        if (timer_item->timer == timer) {
            ~~~~~~~~~~~~~~~~~ ^  ~~~~~
/home/johannes/dev/sway/swaybar/event_loop.c:130:17: error: implicit declaration of function 'timer_getoverrun' is invalid in C99
      [-Werror,-Wimplicit-function-declaration]
                int overrun = timer_getoverrun(item->timer);

johalun · 2017-07-07T11:49:55Z

Hmm I'm getting some weird behavior where the background is treated as a regular window.
I.e., when I start sway and can see the blue background image and as I launch a program, the background is shrunk and moved to left half of the screen while my new window is on the right half of the screen..

ddevault · 2017-07-07T12:53:46Z

Symptoms typical of an incorrect security configuration. Check the log, it sounds like swaybg doesn't have permission to become the background.

johalun · 2017-07-08T06:40:17Z

@SirCmpwn What kind of security config? Does swaybg need SUID root? Currently I only set 'sway' binary SUID root.

ddevault · 2017-07-08T12:20:14Z

Meaning /etc/sway/security.d/*

ddevault · 2017-07-08T12:20:23Z

man 7 sway-security

johalun · 2017-07-08T18:47:18Z

I have permit /usr/local/bin/swaybg background in /usr/local/etc/sway/security.d/00-defaults and no error message in the log (output of sway command).

ddevault · 2017-07-08T18:48:14Z

And swaybg is indeed installed to that location, is owned by root, and is not a symlink?

johalun · 2017-07-08T18:48:20Z

Hmm, -d gave this:
07/08/17 20:47:39 - [security.c:133] WARNING: unable to read /proc/0/file for security check. Using default policy.

Maybe need some FreeBSDification.

ddevault · 2017-07-08T18:48:23Z

And sway is reading from /usr/local/etc/sway/*?

ddevault · 2017-07-08T18:48:38Z

Aha.

johalun · 2017-07-08T18:50:32Z

Oh, for every mouse event I get
07/08/17 20:47:39 - [security.c:133] WARNING: unable to read /proc/0/file for security check. Using default policy.

johalun · 2017-07-08T19:29:16Z

Ok, so this is what we need to do:
http://www.masterraghu.com/subjects/np/introduction/unix_network_programming_v1.3/ch15lev1sec8.html

I can implement it on Monday (possible tomorrow Sunday).

ddevault · 2017-07-08T19:30:17Z

Alright, I'm just going to hold off rc4 until then and ship 0.14 a week after whenever that happens to land.

johalun · 2017-07-09T05:33:53Z

Great. Just a note, a log output or error message instead of silently failing on non-linux OS would be nice :)

Edit: paste this

static pid_t get_client_pid(int client_fd) {
// FreeBSD supports getting uid/gid, but not pid
#ifdef __linux__
	struct ucred ucred;
	socklen_t len = sizeof(struct ucred);

	if (getsockopt(client_fd, SOL_SOCKET, SO_PEERCRED, &ucred, &len) == -1) {
		return -1;
	}

	return ucred.pid;
#else
	return -1;
#endif
}

johalun · 2017-07-09T11:46:14Z

@SirCmpwn Hmm, this wasn't so easy after all without modifying the client code. Maybe go ahead with the release while I figure out how to solve this.

ddevault · 2017-07-09T13:54:32Z

I don't want to break FreeBSD. We should ship a different configuration on FreeBSD that enables more security features by default for all clients.

johalun · 2017-07-10T08:52:49Z

Simply doing

#ifdef __FreeBSD__
	return IPC_FEATURE_ALL;
#endif

in get_*_policy_mask() and it seems to work fine. For now anyway. Not sure what default policy we should use.

There seem to be a consensus that getting the PID via socket and using that for security is a bad thing. The PID can have changed and is being used by another process so there's a race condition (although time frame for that to happen is minimal...)

johalun · 2017-07-10T08:53:34Z

Btw, how do I set default config in security config file?

Edit: never mind, found it.
By adding /usr/local/etc/sway/security.d/10-freebsd:
permit * fullscreen keyboard mouse background screenshot panel lock

I achieve the same results.

ddevault · 2017-07-10T10:49:56Z

Yeah, something like 10-freebsd is what I was suggesting. Can you add a file like it (with a comment in the file explaining its necessity) that's installed on FreeBSD systems?

There seem to be a consensus that getting the PID via socket and using that for security is a bad thing. The PID can have changed and is being used by another process so there's a race condition (although time frame for that to happen is minimal...)

Meh, we can assume that a process isn't giving away its i3 IPC handles willy nilly and that even if it did we could probably trust it to not be stupid enough to give it to a process that shouldn't have access to its security permissions.

johalun · 2017-07-11T08:27:14Z

Yeah, in Sway there shouldn't be any problems. But imagine someone hanging on to a pid of a crashed client, could have some unwanted consequences if the pid is reused by another program.. This will be tricky to solve without having the clients sending pid or binary path info to the compositor :(

Edit: Instead of #ifdef linux maybe we can simply do #ifdef SO_PEERCRED?

ddevault · 2017-07-11T14:20:30Z

Yeah, in Sway there shouldn't be any problems. But imagine someone hanging on to a pid of a crashed client, could have some unwanted consequences if the pid is reused by another program..

This seems unlikely, if not impossible. The file descriptor certainly would not remain valid between the two programs even if they shared a pid.

This will be tricky to solve without having the clients sending pid or binary path info to the compositor :(

This would not work because the clients can lie.

ddevault · 2017-07-12T00:09:15Z

0.14-rc4: https://github.com/SirCmpwn/sway/releases/tag/0.14-rc4

ddevault · 2017-07-18T23:23:49Z

rc5: https://github.com/SirCmpwn/sway/releases/tag/0.14-rc5

Please actually test this one guys, we're already way behind schedule.

ddevault · 2017-07-26T23:22:12Z

Sway 0.14.0 has been released:

https://github.com/SirCmpwn/sway/releases/tag/0.14.0

ddevault closed this as completed Jul 26, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

0.14 #1237

0.14 #1237

ddevault commented Jun 14, 2017

ddevault commented Jun 15, 2017 •

edited

Loading

WhyNotHugo commented Jun 15, 2017

ddevault commented Jun 15, 2017

4e554c4c commented Jun 15, 2017

soredake commented Jun 15, 2017

4e554c4c commented Jun 15, 2017

soredake commented Jun 15, 2017

ddevault commented Jun 23, 2017

ddevault commented Jun 29, 2017

johalun commented Jul 7, 2017

johalun commented Jul 7, 2017 •

edited

Loading

ddevault commented Jul 7, 2017

johalun commented Jul 8, 2017 •

edited

Loading

ddevault commented Jul 8, 2017

ddevault commented Jul 8, 2017

johalun commented Jul 8, 2017

ddevault commented Jul 8, 2017

johalun commented Jul 8, 2017

ddevault commented Jul 8, 2017

ddevault commented Jul 8, 2017

johalun commented Jul 8, 2017

johalun commented Jul 8, 2017

ddevault commented Jul 8, 2017

johalun commented Jul 9, 2017 •

edited

Loading

johalun commented Jul 9, 2017

ddevault commented Jul 9, 2017

johalun commented Jul 10, 2017

johalun commented Jul 10, 2017 •

edited

Loading

ddevault commented Jul 10, 2017

johalun commented Jul 11, 2017 •

edited

Loading

ddevault commented Jul 11, 2017

ddevault commented Jul 12, 2017 •

edited

Loading

ddevault commented Jul 18, 2017

ddevault commented Jul 26, 2017

0.14 #1237

0.14 #1237

Comments

ddevault commented Jun 14, 2017

ddevault commented Jun 15, 2017 • edited Loading

Changes

New Features

Bugs fixed

WhyNotHugo commented Jun 15, 2017

ddevault commented Jun 15, 2017

4e554c4c commented Jun 15, 2017

soredake commented Jun 15, 2017

4e554c4c commented Jun 15, 2017

soredake commented Jun 15, 2017

ddevault commented Jun 23, 2017

ddevault commented Jun 29, 2017

johalun commented Jul 7, 2017

johalun commented Jul 7, 2017 • edited Loading

ddevault commented Jul 7, 2017

johalun commented Jul 8, 2017 • edited Loading

ddevault commented Jul 8, 2017

ddevault commented Jul 8, 2017

johalun commented Jul 8, 2017

ddevault commented Jul 8, 2017

johalun commented Jul 8, 2017

ddevault commented Jul 8, 2017

ddevault commented Jul 8, 2017

johalun commented Jul 8, 2017

johalun commented Jul 8, 2017

ddevault commented Jul 8, 2017

johalun commented Jul 9, 2017 • edited Loading

johalun commented Jul 9, 2017

ddevault commented Jul 9, 2017

johalun commented Jul 10, 2017

johalun commented Jul 10, 2017 • edited Loading

ddevault commented Jul 10, 2017

johalun commented Jul 11, 2017 • edited Loading

ddevault commented Jul 11, 2017

ddevault commented Jul 12, 2017 • edited Loading

ddevault commented Jul 18, 2017

ddevault commented Jul 26, 2017

ddevault commented Jun 15, 2017 •

edited

Loading

johalun commented Jul 7, 2017 •

edited

Loading

johalun commented Jul 8, 2017 •

edited

Loading

johalun commented Jul 9, 2017 •

edited

Loading

johalun commented Jul 10, 2017 •

edited

Loading

johalun commented Jul 11, 2017 •

edited

Loading

ddevault commented Jul 12, 2017 •

edited

Loading