Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing output parsing for pvesh 5.3 #68

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fixing output parsing for pvesh 5.3 #68

wants to merge 1 commit into from

Conversation

pskrzyns
Copy link

@pskrzyns pskrzyns commented Feb 5, 2019

Fixes #67

It looks like #59 and #55 are stucked so I created quick fix.

Important: it won't work with previous versions of pvesh - they dont have --format-output option.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.4%) to 81.579% when pulling 7a7657a on pskrzyns:5.3_formatting_fix into f7874b5 on swayf:develop.

@pskrzyns pskrzyns mentioned this pull request Feb 6, 2019
Open
@com6056
Copy link

com6056 commented Mar 5, 2019

@swayf Any updates on getting this or another fix merged so the SSH backend works for Proxmox 5.3?

@pskrzyns
Copy link
Author

@swayf any update ?

@morph027 morph027 mentioned this pull request Dec 28, 2019
Merged
@morph027
Copy link

@pskrzyns Would you mind re-creating this PR for https://github.com/proxmoxer/proxmoxer ? There's a similar already: proxmoxer/proxmoxer#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems with version 5.3
4 participants
@pskrzyns @coveralls @com6056 @morph027