-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] WNBA players & teams in static data #439
Comments
@rsforbes is there a standard workflow for this? If not, I'll just write my own script to populate this static file. |
@cosmicac - It's a manual workflow that is run via create_static_data_file.py. If we want to add players and teams to the static data file, I think adopting a Thoughts? Happy to work on this over the next week, or you're more than welcome to submit a PR. I'd prefer the latter as time is a little tight on my end. Either works though. :-) |
@rsforbes - thanks for pointing me in the right direction! I'll give this a shot myself. |
Opened #444 to tackle this issue! |
Really looking forward to seeing this added -- I haven't gotten it to work yet! |
First of all, thank you to all of y'all who maintain this package! I've been playing around with it and it's awesome.
I noticed that the WNBA players and teams are not in the static data file. I'm working on something that requires this data.
How is the data in this file generated? Is there a script somewhere in this repository that generates this? I'm happy to open a pull request to add the WNBA players and and teams, but wanted to check to see if there's a standard way the static data is generated.
Thanks!
The text was updated successfully, but these errors were encountered: