Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] WNBA players & teams in static data #439

Closed
cosmicac opened this issue Apr 22, 2024 · 5 comments · Fixed by #444
Closed

[Feature Request] WNBA players & teams in static data #439

cosmicac opened this issue Apr 22, 2024 · 5 comments · Fixed by #444

Comments

@cosmicac
Copy link
Contributor

First of all, thank you to all of y'all who maintain this package! I've been playing around with it and it's awesome.

I noticed that the WNBA players and teams are not in the static data file. I'm working on something that requires this data.

How is the data in this file generated? Is there a script somewhere in this repository that generates this? I'm happy to open a pull request to add the WNBA players and and teams, but wanted to check to see if there's a standard way the static data is generated.

Thanks!

@cosmicac
Copy link
Contributor Author

@rsforbes is there a standard workflow for this? If not, I'll just write my own script to populate this static file.

@rsforbes
Copy link
Collaborator

@cosmicac - It's a manual workflow that is run via create_static_data_file.py.

If we want to add players and teams to the static data file, I think adopting a {variable}_wnba format would work. This way we'd maintain the players for the nba and use players_wnba for the wnba.

Thoughts? Happy to work on this over the next week, or you're more than welcome to submit a PR. I'd prefer the latter as time is a little tight on my end. Either works though. :-)

@cosmicac
Copy link
Contributor Author

@rsforbes - thanks for pointing me in the right direction! I'll give this a shot myself.

@cosmicac
Copy link
Contributor Author

Opened #444 to tackle this issue!

@joshua-d-marcus
Copy link

Really looking forward to seeing this added -- I haven't gotten it to work yet!

@rsforbes rsforbes linked a pull request Oct 9, 2024 that will close this issue
@rsforbes rsforbes closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants