[Security (medium)]: Synk, requests Information Exposure

[rsforbes]

NBA API Version

v1.2.1

Issue

Todo:
Move requests to requests = "^2.31"

Goal: Move to a secure version of requests per the vulnerability and write tests to ensure backward compatibility with the existing API implementation.

[Vulnerability] (https://app.snyk.io/org/rsforbes/project/bb0647cd-7da5-4614-a126-36feab0558ce#issue-SNYK-PYTHON-REQUESTS-5595532):
Detailed paths and remediation
Introduced through: [email protected] › [email protected]
Fix: Upgrade requests to version 2.31.0
Security information
Factors contributing to the scoring:
Snyk: CVSS 6.1 - Medium Severity

NVD: CVSS 6.1 - Medium Severity
Why are the scores different? Learn how Snyk evaluates vulnerability scores
Overview
Affected versions of this package are vulnerable to Information Exposure by leaking Proxy-Authorization headers to destination servers during redirects to an HTTPS origin. This is a result of how rebuild_proxies is used to recompute and reattach the Proxy-Authorization header to requests when redirected.

NOTE: This behavior has only been observed to affect proxied requests when credentials are supplied in the URL user information component (e.g. https://username:password@proxy:8080), and only when redirecting to HTTPS:

HTTP → HTTPS: leak

HTTPS → HTTP: no leak

HTTPS → HTTPS: leak

HTTP → HTTP: no leak

For HTTP connections sent through the proxy, the proxy will identify the header in the request and remove it prior to forwarding to the destination server. However when sent over HTTPS, the Proxy-Authorization header must be sent in the CONNECT request as the proxy has no visibility into further tunneled requests. This results in Requests forwarding the header to the destination server unintentionally, allowing a malicious actor to potentially exfiltrate those credentials.

Code

No response