Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update static players endpoint with 2022 rookie class #270

Closed
scottgoodell opened this issue Oct 7, 2022 · 3 comments · Fixed by #272
Closed

Update static players endpoint with 2022 rookie class #270

scottgoodell opened this issue Oct 7, 2022 · 3 comments · Fixed by #272
Assignees
Labels
enhancement New feature or request

Comments

@scottgoodell
Copy link

It doesn't seem like 2022 rookie class is part of the static players module. Is it possible to update the static players module with the new rookie class in prep for the new season?

Code run:

>>> import nba_api.stats.static.players as players
>>> players.find_player_by_id(1631099)
>>>

For context: 1631099 is Keegan Murray

https://www.nba.com/player/1631099/keegan-murray

Thanks for all the work maintaining this awesome resource!

@rsforbes
Copy link
Collaborator

rsforbes commented Oct 8, 2022

@scottgoodell - Working on some updates this weekend, I'll see if I can't get a release out the first part of the week.

@rsforbes rsforbes added the enhancement New feature or request label Oct 8, 2022
@rsforbes rsforbes self-assigned this Oct 8, 2022
@rsforbes rsforbes linked a pull request Oct 8, 2022 that will close this issue
@rsforbes
Copy link
Collaborator

rsforbes commented Oct 8, 2022

@scottgoodell - I've updated the data.py file. If you want the copy asap, you can download it directly and replace your local file.

Assuming no python knowledge

  1. pip show nba-api will show you where the nba-api package is installed.
  2. Go to that folder and navigate to /stats/library/
  3. Replace data.py with the file above.
> pip show nba-api

Name: nba-api
.
.
Location: {path}/lib/site-packages  <---
.
.

@scottgoodell
Copy link
Author

Perfect thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants