fix(execute): fix encoding of object properties with null value #3726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
char0n
reviewed
Dec 2, 2024
test/oas3/execute/main.js
Outdated
|
|
||
| expect(req).toEqual({ | ||
| method: 'POST', | ||
| url: `/a=null?b=null`, |
There was a problem hiding this comment.
This looks weird. Why would anybody want that? Le't think about this, if it make sense
There was a problem hiding this comment.
As discussed this should have the same semantics as undefined - absence of a value, which is represented by ''
char0n
reviewed
Dec 2, 2024
char0n
approved these changes
Dec 3, 2024
swagger-bot
pushed a commit
that referenced
this pull request
Dec 3, 2024
## [3.32.2](v3.32.1...v3.32.2) (2024-12-03) ### Bug Fixes * **execute:** fix encoding of objects and arrays with null and undefined values ([#3726](#3726)) ([42bd8a9](42bd8a9))
|
🎉 This PR is included in version 3.32.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs swagger-api/swagger-ui#10226
Fixes the issue with
nullandundefinedvalues causing errors due to trying to check their length.