-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue 9178] Handle multiple formats when decoding dates #9730
Conversation
The last version was Swift 3.0 which is very old. The project had some compile errors and was not working at all with Xcode 10. Some changes are generated by Cocoapods using the latest version. Manual fixes are done only for the .swift files
@HugoMario could you check this PR? |
hi @plam4u, sorry for delay, sure, looking now |
@plam4u, unfortunately i'm not so familiar with swift, however i tested locally generating codew with differents inputs and worked fine for me. If you are confident with your changes i can merge them now. |
hi @HugoMario If nobody responds soon, if it is okay with you, you can merge it. Thank you :) |
@plam4u, sure, let's do as you suggest. |
Hi, why the latest version of generator (3.0.22) doesn't use this version of the template? |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.3.0.0
branch for changes related to OpenAPI spec 3.0. Default:master
.Description of the PR
This PR adds multiple date formats discussed and suggested in #9178
When parsing dates, the
CodableHelper
was handling only one specific date format. This means that responses with a different format failed to decode.Changes done: