Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement JSON parser adapter for JSON Schema 2020-12 #4677

Merged
merged 4 commits into from
Jan 23, 2025
Merged

feat: implement JSON parser adapter for JSON Schema 2020-12 #4677

merged 4 commits into from
Jan 23, 2025

Conversation

glowcloud
Copy link
Contributor

Refs #1867

@glowcloud glowcloud added enhancement New feature or request JSON Schema JSON Schema related work labels Jan 23, 2025
@glowcloud glowcloud requested a review from char0n January 23, 2025 09:30
@glowcloud glowcloud self-assigned this Jan 23, 2025
@glowcloud glowcloud added the JSON label Jan 23, 2025
Base automatically changed from 1820-ns-json-schema-2020-12 to main January 23, 2025 13:27
@char0n
Copy link
Member

char0n commented Jan 23, 2025

We need to rebase this branch on top of main and remove the 61472e8 commit to make this PR reviewable.

@glowcloud glowcloud force-pushed the 1867-parser-adapter-json branch from 61472e8 to 1749bda Compare January 23, 2025 13:45
char0n
char0n approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking fine!

@char0n char0n mentioned this pull request Jan 23, 2025
Closed
@char0n
Copy link
Member

char0n commented Jan 23, 2025

Can you please align with current version of 1.0.0-beta.8 ?

@char0n char0n merged commit d7fcb96 into main Jan 23, 2025
8 checks passed
@char0n char0n deleted the 1867-parser-adapter-json branch January 23, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@char0n char0n char0n approved these changes

Assignees

@glowcloud glowcloud

Labels
enhancement New feature or request JSON Schema JSON Schema related work JSON
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glowcloud @char0n