fix: RTK cache & load interval improvements #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppidesu
requested review from
stickyPiston
and removed request for
stickyPiston
|
I know this PR is in draft mode, but it looks good to me! When this PR is ready for review, feel free to request a review from me |
|
Bad news:
RTK Query invalidates the cache upon sending the request, which means we cannot solve this problem with RTK Query alone, and we will have to create a custom cache layer. |
peppidesu
changed the title
peppidesu
changed the title
peppidesu
requested review from
stickyPiston and
KoenDR06
and removed request for
stickyPiston
|
Doesn't the bad news you outlined in your previous comment block this PR? |
KoenDR06
changed the title
|
Could you respond? I genuinely don't know if this PR is ready to be merged or not now. |
|
Hi, sorry for getting back to you so late. No, the PR is not blocked, as it now solves a different problem than was initially intended. |
|
#198 doesn't seem to be fixed for me on this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198.
pollingIntervalto update activities in real-time, as this is useless; The property is used to refetch while component is mounted, but activities unmounts before the first refetch even happens.keepUnusedDataFor: 60 * 60. This is to keep the cache alive even when no components that need it are currently mounted.setupListenerscall to main.tsx to allow RTK query to respond to events like disconnect/reconnectrefetchOnReconnect: trueto every api to force refetch immediately after getting online again.refetchOnMountOrArgChangeto every api to refetch data on mount afterVITE_LOAD_INTERVALseconds have passed, which is how we achieve polling rate.This means that currently, all APIs will only execute a request when:
VITE_LOAD_INTERVALseconds have passed since the last fetch.And will return cached data otherwise (if available)