-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVGO v3 #1429
Comments
Would it make sense to add the txml parser PR (#1301) to the milestone, too? |
Maybe TypeScript? |
Maybe. We already started adding jsdoc for ts. |
Started covering plugins with tsdoc. Quite handy. |
Will this project eventually migrate to TypeScript only? or most files? |
Probably no, I'd like to avoid build step. And tsdoc looks like good enough. |
With tsdoc/esdoc/jsdoc you might want to generate HTML documentation which you can host on GitHub pages. |
Typescript or, at least, ES modules would be great. I created a fork to provide support for Deno some time ago (https://github.com/lumeland/svgo) but it's hard to maintain and update every new version. If the SVGO core used ESM it would be much more easy to adapt for Deno. |
Thank you for this! Not sure about timing. Will try to start working on v3 before the end of the year. |
Btw @oscarotero svgo provides esm module for browsers The entry point is this module https://github.com/svg/svgo/blob/master/lib/svgo.js Instead of https://github.com/svg/svgo/blob/master/lib/svgo-node.js used for node. Can this help with deno? |
Yes, It's the same entry point that I've used in the Deno fork https://github.com/lumeland/svgo/blob/deno/mod.js |
SVGs are not stored in globalThis. Just some dependencies rely on globalThis to cache polyfills. |
Sorry, you're right. I didn't know SVGO exports ES modules. Just tested it and seems to work fine. Thanks! I'd love to have some official Deno support (to take advantage of types for configuration and stuff) but, for now, the browser dist just works. |
If you decide not to use TypeScript you might be interested to generate TypeScript defintion files ( https://www.typescriptlang.org/docs/handbook/declaration-files/dts-from-js.html |
That's not a problem. I'll publish types when whole project migrate to TSDoc. |
Maybe you could generate HTML docs and host it on GitHub Pages then also? |
@vanillajonathan You already wrote about this. Types are not ready yet. |
I meant when you publish the types and when the project has finished its migration to TSDoc. |
Hey @TrySound, Lines 16 to 19 in a9834ef
something like this?
|
svgo v3.0 is released. Is this issue still up to date? |
Just a list of possible changes
drop commonjs supportenable remove-xlink-ns by default ([new plugin] remove-xlink-ns #1535)The text was updated successfully, but these errors were encountered: