Plugin reusePaths implicitly depends on removeXMLProcInst being enabled

[mrackwitz]

As the title states, the plugin reusePaths implicitly depends on removeXMLProcInst being enabled. I think this should be at least documented – better fixed.

If a document has an XML processing instruction and the plugin removeXMLProcInst is disabled, then said element is preceding the root element, which the implementation of the reusePaths does not properly handle. This causes the following crash:

TypeError: Cannot read property 'splice' of undefined
    at module.exports.JSAPI.spliceContent (<#REDACTED#>/node_modules/svgo/lib/svgo/jsAPI.js:135:25)
    at Object.exports.fn (<#REDACTED#>/node_modules/svgo/plugins/reusePaths.js:126:19)
    at <#REDACTED#>/node_modules/svgo/lib/svgo/plugins.js:95:27
    at Array.forEach (<anonymous>)
    at full (<#REDACTED#>/node_modules/svgo/lib/svgo/plugins.js:93:13)
    at <#REDACTED#>/node_modules/svgo/lib/svgo/plugins.js:25:24
    at Array.forEach (<anonymous>)
    at module.exports (<#REDACTED#>/node_modules/svgo/lib/svgo/plugins.js:15:13)
    at <#REDACTED#>/node_modules/svgo/lib/svgo.js:70:17
    at SAXParser.sax.onend (<#REDACTED#>/node_modules/svgo/lib/svgo/svg2js.js:169:13)

The problem is here:

svgo/plugins/reusePaths.js

Lines 124 to 126 in 07ca976

	const defsTag = new JSAPI({
	elem: 'defs', prefix: '', local: 'defs', content: [], attrs: []}, data);
	data.content[0].spliceContent(0, 0, defsTag);

[TrySound]

Fixed in #1551. Will be released soon.

[TrySound]

Fixed in https://github.com/svg/svgo/releases/tag/v2.6.0