Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for .NET Core? #248

Closed
UweKeim opened this issue Aug 12, 2016 · 4 comments
Closed

Support for .NET Core? #248

UweKeim opened this issue Aug 12, 2016 · 4 comments

Comments

@UweKeim
Copy link

UweKeim commented Aug 12, 2016

Do you any plans to support your library running on .NET Core in the near future?

@mmosca
Copy link

mmosca commented Jul 20, 2017

I just submited a pull request to add support for .Netstandard 2.0 ( #326 )

This should allow you to use it with .Net Core once .Net core 2.0 is released in a few months.

@ljcorreia
Copy link

ljcorreia commented Jun 18, 2018

Thanks @mmosca,

I've tested your pull request and it worked mostly well, however, I'm having issues with one project that I tested exactly the same code used to change the fill colour and it does not seem to be doing the same if comparing the net45 vs netcore.

The discrepancies seem to me the use of CSS-like styling inside SVG, for example:

<style type="text/css">
	.st0{fill:#EE3E33;}
</style>
<g id="Foo">
	<g id="foo_01">
		<path class="st0" d="...."/>
	</g>
</g>

On that SVG snipped, the net45 would pick up the fill colour, but the NetStandard version doesn't. Is that familiar to you? Are styles not supported?

EDIT: In fact, I've tested this further and it does seem to me something to do with the Path (SvgPath). Changing the Fill works for Ellipse, Polygon, but not with SvgPath.

Also, would you please clarify to me as of where does that pull request #326 stands in regards to the use of ZKWeb.System.Drawing as opposed .Net Compatibility Pack?

Thanks
Leo

@mrbean-bremen
Copy link
Member

mrbean-bremen commented May 13, 2019

@UweKeim - can you please check if current master works for you?

@mrbean-bremen
Copy link
Member

Closing this one too in favor of the duplicate with the nicer number - please add comments regarding .NET Core support on that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants