Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test more edge cases and failure modes #27

Open
raffomania opened this issue May 17, 2023 · 0 comments
Open

Test more edge cases and failure modes #27

raffomania opened this issue May 17, 2023 · 0 comments

Comments

@raffomania
Copy link

I really like the test setup and the happy path tests are a good start. Here are some more edge cases that would be really useful to test, preparing us for the inevitable hetzner failures:

  • What happens when consul crashes, needs to be restarted or becomes unavailable in any way? Should we just give up, or should we add a retry logic for recovery?
  • Same if the network is not reachable when starting (see recent hetzner issues). We can't do anything there and I wouldn't expect wiresmith to do anything but crash. It would still be good to cover this case in tests, if only for documentation purposes.
  • Nodes that become unreachable are removed from other peers after a certain timeframe. This should be tested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant