Fix compatibility with --frozen-string-literal
#1120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
fstr
branch
2 times, most recently
from
b764cb2 to
219f6db
Compare
tferrerm
reviewed
Jun 4, 2024
|
@pama sorry for the ping, but any chance to get this merged? |
sunny
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Thank you @casperisfine for your work on bringing this to gems themselves 👏🏻
Would you mind adding an entry to the CHANGELOG as well? 🙏🏻
This option has been available since a long time, but many gems don't support it, I'm trying to fix that. Also it's not unlikely that this will become the default a few years down the line: https://bugs.ruby-lang.org/issues/20205
|
@sunny done! |
pama
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option has been available since a long time, but many gems don't support it, I'm trying to fix that.
Also it's not unlikely that this will become the default a few years down the line: https://bugs.ruby-lang.org/issues/20205