Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error handling of github api errors #46

Closed
nosovk opened this issue Aug 24, 2023 · 1 comment
Closed

add error handling of github api errors #46

nosovk opened this issue Aug 24, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@nosovk
Copy link

nosovk commented Aug 24, 2023

Time to time GitHub API can go down, and make responses with 5xx codes and body like that:

{
   "data": null,
   "errors":[
      {
         "message":"Something went wrong while executing your query. This may be the result of a timeout, or it could be a GitHub bug. Please include `DF4A:6E1B:1D670F9:1DAA64D:64E7DC75` when reporting this issue."
      }
   ]
}

It would be nice to show some error modal with "Retry" button to retry the request.
No errors silently ignored :(

@kyoshino
Copy link
Member

Netlify CMS has a background service status check and shows an alert when the Git backend is down.

decaporg/decap-cms#3889

I think we need this and took a screenshot before:

Screenshot 2023-02-17 at 11 42 58 PM

The English label is

The backend service is experiencing an outage. See %{details} for more information

@kyoshino kyoshino added the enhancement New feature or request label Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants