Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] modal transition #430

Closed
twoco opened this issue Jul 22, 2023 · 1 comment
Closed

[Improvement] modal transition #430

twoco opened this issue Jul 22, 2023 · 1 comment
Labels
component New or changes to components enhancement New feature or request

Comments

@twoco
Copy link

twoco commented Jul 22, 2023

It would be great if we could define custom transition for e.g. modals. In best case with global configuration. But let me explain why I created this issue:

The current transition looks a bit rough. Because the scale from 0 to 1. I would start from 0.5 or 0.9.

You could also just set the start option for the scale. With the change I would not really need a custom transition.

Here is my suggestion. You can play with the values if you like. Maybe this is matter of taste. Just try it out.

<div 
  class={classes.transition} 
  transition:scale={{ duration: 200, easing: cubicOut, start: 0.9 }}
>
  ...
</div>

docs | source

@BeeMargarida BeeMargarida added enhancement New feature or request component New or changes to components labels Jul 23, 2023
@BeeMargarida
Copy link
Member

I think this can be improved by adding a prop for the transition options, so that there's more control about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component New or changes to components enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants