Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub name gets borked if it contains accented characters #236

Closed
Rich-Harris opened this issue Mar 27, 2018 · 2 comments
Closed

GitHub name gets borked if it contains accented characters #236

Rich-Harris opened this issue Mar 27, 2018 · 2 comments
Labels
bug

Comments

@Rich-Harris
Copy link
Member

Say you happen to be called Maurício Kishi, and you log in to the REPL. When the logging in happens client-side, it renders as 'MaurĆ­cio Kishi' instead. The server-rendered page is fine.

Not sure yet if this is a Sapper issue or just related to the mechanism for transferring user data from the pop-up dialog

cc @mrkishi
@Rich-Harris
Copy link
Member Author

d'oh, @Conduitry already fixed it (25c456c)

@mrkishi
Copy link
Member

mrkishi commented Mar 27, 2018

@Conduitry actually found the issue in 25c456c!

@Conduitry Conduitry mentioned this issue Mar 27, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrkishi @Rich-Harris