From e4729536a99fbdbcec2904aee7f7fb0d63612dfb Mon Sep 17 00:00:00 2001 From: Simon Holthausen Date: Wed, 17 Jul 2024 22:26:58 +0200 Subject: [PATCH 1/2] fix: set volume through DOM property Already works when using spread attributes, but not when setting it on its own fixes #12029 --- packages/svelte/src/compiler/phases/constants.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/svelte/src/compiler/phases/constants.js b/packages/svelte/src/compiler/phases/constants.js index 4201e54c7771..898a77c4bf4b 100644 --- a/packages/svelte/src/compiler/phases/constants.js +++ b/packages/svelte/src/compiler/phases/constants.js @@ -4,6 +4,7 @@ export const DOMProperties = [ ...Object.values(AttributeAliases), 'value', 'inert', + 'volume', ...DOMBooleanAttributes ]; From 76498a18dbeb7acb30f2b0195a2b858974b2fdc8 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Thu, 18 Jul 2024 09:58:20 -0400 Subject: [PATCH 2/2] changeset --- .changeset/shiny-kangaroos-move.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/shiny-kangaroos-move.md diff --git a/.changeset/shiny-kangaroos-move.md b/.changeset/shiny-kangaroos-move.md new file mode 100644 index 000000000000..cde5eb29b52e --- /dev/null +++ b/.changeset/shiny-kangaroos-move.md @@ -0,0 +1,5 @@ +--- +"svelte": patch +--- + +fix: set `volume` through DOM property rather than attribute