From 5abf96a99e01c0b2ddbb47af03d41c4e44009c22 Mon Sep 17 00:00:00 2001 From: navorite Date: Tue, 6 Feb 2024 16:45:32 +0200 Subject: [PATCH 1/2] fix: set initial value for `open` binding in `
` --- .changeset/strange-apricots-happen.md | 5 +++++ packages/svelte/src/compiler/phases/bindings.js | 1 + .../samples/details-binding-initial/_config.js | 11 +++++++++++ .../samples/details-binding-initial/main.svelte | 8 ++++++++ 4 files changed, 25 insertions(+) create mode 100644 .changeset/strange-apricots-happen.md create mode 100644 packages/svelte/tests/runtime-runes/samples/details-binding-initial/_config.js create mode 100644 packages/svelte/tests/runtime-runes/samples/details-binding-initial/main.svelte diff --git a/.changeset/strange-apricots-happen.md b/.changeset/strange-apricots-happen.md new file mode 100644 index 000000000000..a3893ec3bdfc --- /dev/null +++ b/.changeset/strange-apricots-happen.md @@ -0,0 +1,5 @@ +--- +'svelte': patch +--- + +fix: set initial value for `open` binding in `
` diff --git a/packages/svelte/src/compiler/phases/bindings.js b/packages/svelte/src/compiler/phases/bindings.js index d8f04e173276..820c66d886ff 100644 --- a/packages/svelte/src/compiler/phases/bindings.js +++ b/packages/svelte/src/compiler/phases/bindings.js @@ -175,6 +175,7 @@ export const binding_properties = { textContent: {}, open: { event: 'toggle', + type: 'set', valid_elements: ['details'] }, value: { diff --git a/packages/svelte/tests/runtime-runes/samples/details-binding-initial/_config.js b/packages/svelte/tests/runtime-runes/samples/details-binding-initial/_config.js new file mode 100644 index 000000000000..d0ecf3192306 --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/details-binding-initial/_config.js @@ -0,0 +1,11 @@ +import { ok, test } from '../../test'; + +export default test({ + test({ assert, target }) { + const details_el = target.querySelector('details'); + + ok(details_el); + + assert.strictEqual(details_el.open, true); + } +}); diff --git a/packages/svelte/tests/runtime-runes/samples/details-binding-initial/main.svelte b/packages/svelte/tests/runtime-runes/samples/details-binding-initial/main.svelte new file mode 100644 index 000000000000..fda553038e27 --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/details-binding-initial/main.svelte @@ -0,0 +1,8 @@ + + +
+ Details + ... +
From df39f3f568cbeeaebe0679580a93fc1135189008 Mon Sep 17 00:00:00 2001 From: navorite Date: Tue, 6 Feb 2024 16:52:22 +0200 Subject: [PATCH 2/2] accurate desc --- .changeset/strange-apricots-happen.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/strange-apricots-happen.md b/.changeset/strange-apricots-happen.md index a3893ec3bdfc..d61dfb514989 100644 --- a/.changeset/strange-apricots-happen.md +++ b/.changeset/strange-apricots-happen.md @@ -2,4 +2,4 @@ 'svelte': patch --- -fix: set initial value for `open` binding in `
` +fix: set `open` binding value in `
`