From 4308e7d6e33bbe8593d980a37e6061227397d3fc Mon Sep 17 00:00:00 2001 From: navorite Date: Sun, 31 Dec 2023 19:07:32 +0200 Subject: [PATCH 1/4] fix: add types for popover attributes and events --- packages/svelte/elements.d.ts | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/packages/svelte/elements.d.ts b/packages/svelte/elements.d.ts index 93949b59d753..97f3b61c9c82 100644 --- a/packages/svelte/elements.d.ts +++ b/packages/svelte/elements.d.ts @@ -59,6 +59,7 @@ export type WheelEventHandler = EventHandler = EventHandler; export type TransitionEventHandler = EventHandler; export type MessageEventHandler = EventHandler; +export type ToggleEventHandler = EventHandler; // // DOM Attributes @@ -94,6 +95,10 @@ export interface DOMAttributes { 'on:load'?: EventHandler | undefined | null; 'on:error'?: EventHandler | undefined | null; // also a Media Event + // Popover Events + 'on:beforetoggle'?: ToggleEventHandler | undefined | null; + 'on:toggle'?: ToggleEventHandler | undefined | null; + // Detail Events 'on:toggle'?: EventHandler | undefined | null; @@ -517,6 +522,7 @@ export interface HTMLAttributes extends AriaAttributes, D title?: string | undefined | null; translate?: 'yes' | 'no' | '' | undefined | null; inert?: boolean | undefined | null; + popover?: 'auto' | 'manual' | '' | undefined | null; // Unknown radiogroup?: string | undefined | null; // , @@ -584,9 +590,9 @@ export interface HTMLAttributes extends AriaAttributes, D 'bind:innerText'?: string | undefined | null; readonly 'bind:contentRect'?: DOMRectReadOnly | undefined | null; - readonly 'bind:contentBoxSize'?: Array | undefined | null; - readonly 'bind:borderBoxSize'?: Array | undefined | null; - readonly 'bind:devicePixelContentBoxSize'?: Array | undefined | null; + readonly 'bind:contentBoxSize'?: ResizeObserverSize[] | undefined | null; + readonly 'bind:borderBoxSize'?: ResizeObserverSize[] | undefined | null; + readonly 'bind:devicePixelContentBoxSize'?: ResizeObserverSize[] | undefined | null; // SvelteKit 'data-sveltekit-keepfocus'?: true | '' | 'off' | undefined | null; @@ -627,7 +633,7 @@ export interface HTMLAnchorAttributes extends HTMLAttributes 'sapper:prefetch'?: true | undefined | null; } -export interface HTMLAudioAttributes extends HTMLMediaAttributes {} +export type HTMLAudioAttributes = HTMLMediaAttributes; export interface HTMLAreaAttributes extends HTMLAttributes { alt?: string | undefined | null; @@ -663,6 +669,8 @@ export interface HTMLButtonAttributes extends HTMLAttributes name?: string | undefined | null; type?: 'submit' | 'reset' | 'button' | undefined | null; value?: string | string[] | number | undefined | null; + popovertarget?: string | undefined | null; + popovertargetaction?: 'toggle' | 'show' | 'hide' | undefined | null; } export interface HTMLCanvasAttributes extends HTMLAttributes { From 489324fb0b6379c9dda15e300907a05b3d70628c Mon Sep 17 00:00:00 2001 From: navorite Date: Sun, 31 Dec 2023 19:11:15 +0200 Subject: [PATCH 2/4] changeset --- .changeset/eight-swans-occur.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/eight-swans-occur.md diff --git a/.changeset/eight-swans-occur.md b/.changeset/eight-swans-occur.md new file mode 100644 index 000000000000..f2436dd5feab --- /dev/null +++ b/.changeset/eight-swans-occur.md @@ -0,0 +1,5 @@ +--- +'svelte': patch +--- + +fix: add types for popover attributes and events From cf1e32c6f09b92a22eea5ca2a236efea524c2a31 Mon Sep 17 00:00:00 2001 From: navorite Date: Sun, 31 Dec 2023 19:30:45 +0200 Subject: [PATCH 3/4] move details toggle event to its interface --- packages/svelte/elements.d.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/svelte/elements.d.ts b/packages/svelte/elements.d.ts index 97f3b61c9c82..977931050831 100644 --- a/packages/svelte/elements.d.ts +++ b/packages/svelte/elements.d.ts @@ -99,9 +99,6 @@ export interface DOMAttributes { 'on:beforetoggle'?: ToggleEventHandler | undefined | null; 'on:toggle'?: ToggleEventHandler | undefined | null; - // Detail Events - 'on:toggle'?: EventHandler | undefined | null; - // Keyboard Events 'on:keydown'?: KeyboardEventHandler | undefined | null; 'on:keypress'?: KeyboardEventHandler | undefined | null; @@ -695,6 +692,8 @@ export interface HTMLDetailsAttributes extends HTMLAttributes | undefined | null; } export interface HTMLDelAttributes extends HTMLAttributes { From 71229b8ecada0adc7ed59368eeb008390ea4efcd Mon Sep 17 00:00:00 2001 From: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Tue, 2 Jan 2024 12:53:45 +0100 Subject: [PATCH 4/4] fix --- packages/svelte/elements.d.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/svelte/elements.d.ts b/packages/svelte/elements.d.ts index 977931050831..25342b07d117 100644 --- a/packages/svelte/elements.d.ts +++ b/packages/svelte/elements.d.ts @@ -630,7 +630,7 @@ export interface HTMLAnchorAttributes extends HTMLAttributes 'sapper:prefetch'?: true | undefined | null; } -export type HTMLAudioAttributes = HTMLMediaAttributes; +export interface HTMLAudioAttributes extends HTMLMediaAttributes {} export interface HTMLAreaAttributes extends HTMLAttributes { alt?: string | undefined | null; @@ -693,7 +693,7 @@ export interface HTMLDetailsAttributes extends HTMLAttributes | undefined | null; + 'on:toggle'?: EventHandler | undefined | null; } export interface HTMLDelAttributes extends HTMLAttributes {