Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auto preprocess] Don't try to preprocess unknown language #312

Closed
kaisermann opened this issue Feb 10, 2021 · 1 comment · Fixed by #622
Closed

[auto preprocess] Don't try to preprocess unknown language #312

kaisermann opened this issue Feb 10, 2021 · 1 comment · Fixed by #622
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@kaisermann
Copy link
Member

kaisermann commented Feb 10, 2021

Originally posted by @kaisermann in #305 (comment)

In auto preprocess mode, we currently error out if the lib encounters an unknown language/transformer. We could just skip instead and let another preprocessor handle it. This seems to be another reason to rewrite the auto preprocess module (as mentioned in #311).

@kaisermann kaisermann added enhancement New feature or request help wanted Extra attention is needed labels Feb 10, 2021
@kaisermann kaisermann changed the title Don't try to preprocess unknown language [auto preprocess] Don't try to preprocess unknown language Feb 10, 2021
@benmccann
Copy link
Member

Addressing this would also simplify partytown setup: https://partytown.builder.io/sveltekit#4-optional-svelte-preprocess-configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants