breaking: new options, deprecate svelteStrictMode #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: Remove deprecated concat * Remove Concat node checks
Updates the code base to using prettier v3. This required a refactoring of embeds since the call timing is now different --------- Co-authored-by: Simon H <[email protected]> Co-authored-by: Rolaka <[email protected]> Co-authored-by: Simon Holthausen <[email protected]>
- add `svelteSelfCloseComponents` and `svelteSelfCloseElements` to specify whether or not empty elements/components should self-close. `svelteStrictMode` no longer has any effect on this behavior - `svelteAllowShorthand` now takes precedence over `svelteStrictMode`, which no longer has any effect on that behavior - `svelteStrictMode` is deprecated as future Svelte versions might coerce numbers coming from mustache tags inside strings into strings closes #348 closes #284 closes #279 closes #238 related to #377
|
To summarize what I said in Discord: I don't think we should have either For elements, I think we should either leave them as the user wrote them, or else rewrite them according to whether they're a valid void element in HTML (even though the Svelte compiler doesn't care about that). I don't have a strong opinion one way or the other. For components, leaving it as the user wrote it would probably be fine, if that's what Prettier does for JSX. |
dummdidumm
added a commit
that referenced
this pull request
Jul 14, 2023
- whether or not empty elements/components should self-close is now left to the user - in other words, if you write `<div />` or `<Component />` that stays as is, and so does `<div></div>`/`<Component></Component>`. `svelteStrictMode` no longer has any effect on this behavior - `svelteAllowShorthand` now takes precedence over `svelteStrictMode`, which no longer has any effect on that behavior - `svelteStrictMode` is deprecated as future Svelte versions might coerce numbers coming from mustache tags inside strings into strings closes #348 closes #284 closes #279 closes #238 related to #377 superseeds / closes #379 as less options = better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
svelteSelfCloseComponentsandsvelteSelfCloseElementsto specify whether or not empty elements/components should self-close.svelteStrictModeno longer has any effect on this behavior.<div></div>it stays as this, and if the user says<div />that also stays like this. This is what Prettier currently does in both HTML and JSXsvelteAllowShorthandnow takes precedence oversvelteStrictMode, which no longer has any effect on that behaviorsvelteStrictModeis deprecated as future Svelte versions might coerce numbers coming from mustache tags inside strings into stringscloses #348
closes #284
closes #279
closes #238
related to #377