Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearly State ENV exposure #4746

Closed
MentalGear opened this issue Apr 26, 2022 · 2 comments
Closed

Clearly State ENV exposure #4746

MentalGear opened this issue Apr 26, 2022 · 2 comments
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@MentalGear
Copy link

MentalGear commented Apr 26, 2022

Describe the problem

https://kit.svelte.dev/faq#env-vars
Update docs to clearly state where VITE_ envs are exposed in sveltekit. Being unsure about this may lead to poor security design.

Describe the proposed solution

A highlighted info that says: VITE_ Envs are exposed to the client ! You might want to use VITE_PUBLIC_KEY to indicate this.

Alternatives considered

No response

Importance

would make my life easier

Additional Information

No response

@Rich-Harris Rich-Harris added the documentation Improvements or additions to documentation label Apr 26, 2022
@Rich-Harris Rich-Harris added this to the whenever milestone Apr 26, 2022
@luisgabrielm
Copy link

Hello @MentalGear. I agree with the need for better documentation regarding env, but there's an open discussion happening about the future of env vars in Svelte Kit: #4296

I think it might make sense to wait and see how that will play out before rewriting the docs. What do you think?

@Rich-Harris
Copy link
Member

Closing as outdated (environment variables should now be accessed via the $env modules, not through import.meta.env)

@Rich-Harris Rich-Harris closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants