-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include a default adapter for the demo project #2459
Comments
I'm against adding a default. I'm ambivalent about adding an option to |
Sure, I get the reasoning behind not adding a default, but I think adding an option to |
Adding it to |
related to: #2246 I mean it would be good to have option to add adapter in initializing project, but default should still be "I don't know yet / a different adapter". As dummdidumm wrote. |
I'm interested in working on this. |
Sounds fine to me. The default should probably be something like "Not now. I'll add it later or will use a community-provided adapter (https://bit.ly/3kvqIRy)" Right now the list of community adapters at sveltesociety.dev is pre-rendered at build-time for that site. But we could probably send a PR to add an API endpoint to that site exposing the list of adapters. Then we could also allow you to choose from them as well |
This can be closed, both demo apps include |
Describe the problem
I installed the demo project and tried to build, but got an error mentioning that no adapter was specified, which seems somewhat confusing as a default experience.
Describe the proposed solution
Default the demo project to the static adapter/node adapter (not sure which is more appropriate), or add a question to the setup (along with whether to enable Typescript etc...) that defaults to including an adapter.
Alternatives considered
No response
Importance
nice to have
Additional Information
No response
The text was updated successfully, but these errors were encountered: