files in $service-worker should contain prerendered files

[frederikhors]

Using adapter-static and the code:

import { files } from '$service-worker';

I expect to find also the <NAME>.html fallback file listed in files.

Am I wrong?

[ignatiusmb]

Please provide a complete and minimal reproducible example of what happen and should've happen.

[Mlocik97]

this is specific for adapter, so it's not good if it's provided by $service-worker, why You don't simply add manually that file to it? It's just one line of code.

[benmccann]

For fallback we can add just the one. For prerendered files there might be too many to do this. We'd have to have the adapter generate the manifest after prerendering I guess? Or maybe we can somehow do SSG during Vite build, which I think vitepress might do

[userquin]

@frederikhors The problem is that any adapter used is called after svelte finish build process, so calling/building the service worker module cannot have those files.

@benmccann vitepress right now has not pwa support: you can see how I regenerate the vite-plugin-pwa docs using vitepress and executing again the pwa build process for build it (on build script on docs package.json file), that is, after vitepress build finish.

I have a branch on my fork of vitepress with the build module using the vite-plugin-pwa api like the svelte kit one (on my fork):

• https://github.com/userquin/kit/blob/feat/add-vite-plugin-pwa/packages/kit/src/cli.js#L108 and https://github.com/userquin/kit/blob/feat/add-vite-plugin-pwa/packages/kit/src/cli.js#L145
• https://github.com/userquin/vitepress/blob/feat/pwa-support/src/node/build/build.ts#L16, https://github.com/userquin/vitepress/blob/feat/pwa-support/src/node/build/build.ts#L81 and https://github.com/userquin/vitepress/blob/feat/pwa-support/src/node/build/pwa.ts

[userquin]

@ignatiusmb you can build and preview the https://github.com/svelte-society/sveltesociety.dev: before building it, just add a service worker file and log the files entry from service worker module.

You can see the expected output on this branch on my fork of svelte-society, using the vite-plugin-pwa, just build the project and see sw.js generated file from vite-plugin-pwa: https://github.com/userquin/sveltesociety.dev.

On following screenshot, all these pages (there are a lot more) are missing from the service worker module (and for that reason, apps using service worker module cannot run on offline: if you preview my master branch fork, all pages will work on offline).

[benmccann]

SvelteKit's own service worker should contain prerendered files now. Unfortunately, it still doesn't happen early enough in the build process that plugins like vite-plugin-pwa could pick them up