Merge branch 'sveltejs:main' into fix/css-inlining-map-collision

Author: tkhs0813

.changeset/config.json

@@ -6,5 +6,5 @@
 	"access": "public",
 	"baseBranch": "main",
 	"bumpVersionsWithWorkspaceProtocolOnly": true,
-	"ignore": ["!(@sveltejs/*|create-svelte)"]
+	"ignore": ["!(@sveltejs/*)"]
 }

.changeset/happy-beers-remain.md

@@ -0,0 +1,55 @@
+// @ts-expect-error no types here
+import path from 'node:path';
+
+/**
+ * @type {import('eslint').Rule.RuleModule}
+ */
+export default {
+	meta: {
+		type: 'problem',
+		docs: {
+			description: 'disallow relative imports from src/runtime to src/exports',
+			category: 'Possible Errors',
+			recommended: true
+		},
+		schema: [],
+		messages: {
+			noRuntimeToExportsImport:
+				'Relative imports from src/runtime to src/exports are not allowed because they can cause Vite to resolve the same module both via regular Node and internal Vite. Use internal import maps or `@sveltejs/kit/internal` instead.'
+		}
+	},
+
+	create(context) {
+		const filename = context.filename;
+
+		// Only apply this rule to files in packages/kit/src/runtime
+		const in_runtime = filename.includes(path.join('packages', 'kit', 'src', 'runtime'));
+
+		if (!in_runtime) {
+			return {};
+		}
+
+		return {
+			ImportDeclaration(node) {
+				const import_path = node.source.value;
+
+				// Check if this is a relative import
+				if (typeof import_path === 'string' && import_path.startsWith('.')) {
+					// Resolve the import path relative to the current file
+					const current_dir = path.dirname(filename);
+					const resolved_path = path.resolve(current_dir, import_path);
+
+					// Check if the resolved path points to src/exports
+					const exports_path = path.join('packages', 'kit', 'src', 'exports');
+
+					if (resolved_path.includes(exports_path)) {
+						context.report({
+							node: node.source,
+							messageId: 'noRuntimeToExportsImport'
+						});
+					}
+				}
+			}
+		};
+	}
+};

.changeset/tricky-pants-kick.md

@@ -0,0 +1,210 @@
+# SvelteKit Development Instructions
+
+SvelteKit is a web application framework for building modern web applications with Svelte. This is a monorepo containing @sveltejs/kit, adapters, and related packages.
+
+**Always reference these instructions first and fallback to search or bash commands only when you encounter unexpected information that does not match the info here.**
+
+## Working Effectively
+
+### Prerequisites and Setup
+- Install Node.js 18+ (current tested versions: 18, 20, 22, 24)
+- Install pnpm globally: `npm install -g pnpm` (takes ~2 seconds)
+- Clone the repository: `git clone [email protected]:sveltejs/kit.git`
+- Navigate to the repository: `cd kit`
+
+### Bootstrap and Build Commands
+- **CRITICAL**: Install dependencies: `pnpm install --frozen-lockfile`
+  - **NEVER CANCEL**: Takes 3-4 minutes. Set timeout to 10+ minutes.
+- Sync generated files: `pnpm run sync-all` (takes <1 second)
+- Build all packages: `pnpm build` (takes ~1-2 seconds)
+
+### Development Commands
+- **Format code**: `pnpm run format` (takes ~15 seconds)
+- **Lint code**: `pnpm run lint` 
+  - **NEVER CANCEL**: Takes 2-3 minutes. Set timeout to 5+ minutes.
+- **Type checking**: `pnpm run check`
+  - **NEVER CANCEL**: Takes 3-4 minutes. Set timeout to 8+ minutes.
+- **Run unit tests**: `cd packages/kit && pnpm test:unit` (takes ~6 seconds)
+
+### Testing Commands
+- **Unit tests only**: `cd packages/kit && pnpm test:unit` (takes ~6 seconds)
+- **Integration tests**: `pnpm test:kit`
+  - **NEVER CANCEL**: Takes 10-30 minutes. Set timeout to 60+ minutes.
+  - **Requires browser setup**: `pnpm playwright install chromium` first
+- **Other package tests**: `pnpm test:others`
+  - **NEVER CANCEL**: Takes 5-15 minutes. Set timeout to 30+ minutes.
+  - **Requires browser setup**: `pnpm playwright install chromium` first
+
+### Development Server (Playground)
+- Navigate to playground: `cd playgrounds/basic`
+- Start dev server: `pnpm run dev`
+- Server starts at: `http://localhost:5173/`
+- Dev server starts in ~1-2 seconds
+
+## Validation Requirements
+
+### ALWAYS run these before submitting changes:
+1. `pnpm run format` - Auto-format all code
+2. `pnpm run lint` - Check code style (NEVER CANCEL - takes 2-3 minutes)
+3. `pnpm run check` - Type checking (NEVER CANCEL - takes 3-4 minutes)
+4. `cd packages/kit && pnpm test:unit` - Run unit tests
+5. **For changes to @sveltejs/kit**: `cd packages/kit && pnpm prepublishOnly` - Generate types
+
+#### Add changeset once you're done
+
+Run `pnpm changeset` then follow the prompts. Use this after having finished the task. Most of the time this is a patch release for `@sveltejs/kit`. Use a short and descriptive message. Always prefix the message with either `fix`, `feat`, `breaking`, or `chore` (most likely `fix` since you're mostly working on bugfixes). Example: `fix: run load functions in order`. Use the same message as the title of your pull request.
+
+### Manual Testing Scenarios
+**ALWAYS test these scenarios after making changes:**
+
+1. **Create a new SvelteKit app**: 
+   ```bash
+   cd /tmp
+   npx sv create test-app --template minimal --no-install --no-types
+   # Press Enter to skip additional packages
+   cd test-app
+   
+   # Use pnpm if available, otherwise fall back to npm
+   if command -v pnpm &> /dev/null; then
+     pnpm install
+     # Link local @sveltejs/kit development version by adding pnpm overrides
+     # Replace PATH_TO_KIT_REPO with the actual path to your kit repository
+     npm pkg set 'pnpm.overrides.@sveltejs/kit'='link:PATH_TO_KIT_REPO/packages/kit'
+     pnpm install --no-frozen-lockfile
+     pnpm run dev
+   else
+     npm install
+     # For npm, manually link the local package
+     # Replace PATH_TO_KIT_REPO with the actual path to your kit repository
+     npm link PATH_TO_KIT_REPO/packages/kit
+     npm run dev
+   fi
+   ```
+   - Verify the app starts and loads at http://localhost:5173/
+   - Verify it's using the local @sveltejs/kit version (check that `node_modules/@sveltejs/kit` is a symlink)
+
+2. **Test the CLI**:
+   ```bash
+   cd packages/kit
+   node svelte-kit.js --help
+   node svelte-kit.js sync --help
+   ```
+
+3. **Test playground functionality**:
+   ```bash
+   cd playgrounds/basic
+   pnpm run dev
+   ```
+   - Navigate to http://localhost:5173/
+   - Test basic navigation and functionality
+
+## Repository Structure
+
+### Key Packages (`packages/` directory):
+- **@sveltejs/kit** - Main SvelteKit package (`packages/kit/`)
+- **Adapters**: adapter-auto, adapter-cloudflare, adapter-netlify, adapter-node, adapter-static, adapter-vercel
+- **@sveltejs/enhanced-img** - Enhanced image component
+- **@sveltejs/package** - Package building utilities
+- **@sveltejs/amp** - AMP support
+
+### Key Directories:
+- `packages/kit/src/core/` - Build-time code
+- `packages/kit/src/runtime/` - Runtime code  
+- `packages/kit/src/exports/vite/` - Vite plugin
+- `packages/kit/test/` - Integration tests
+- `playgrounds/basic/` - Development playground
+- `.github/workflows/` - CI/CD configuration
+
+### Important Files:
+- `pnpm-workspace.yaml` - Workspace configuration
+- `package.json` - Root package with scripts
+- `packages/kit/svelte-kit.js` - CLI entry point
+- `packages/kit/package.json` - Main package configuration
+
+## Common Tasks
+
+### Working with Types
+- Generate types: `cd packages/kit && pnpm generate:types`
+- Check types: `cd packages/kit && pnpm prepublishOnly`
+- **CRITICAL**: Always commit generated type changes
+
+### Testing Specific Changes
+- Link local changes to external project using `pnpm.overrides` in external project's package.json:
+  ```json
+  {
+    "pnpm": {
+      "overrides": {
+        "@sveltejs/kit": "link:../path/to/kit/packages/kit"
+      }
+    }
+  }
+  ```
+
+### Working with Adapters
+- Each adapter has its own test suite
+- Build adapter: `cd packages/adapter-[name] && pnpm build`
+- Test adapter: `cd packages/adapter-[name] && pnpm test`
+
+## Timing Expectations
+
+**Set these timeout values for long-running commands:**
+
+| Command | Expected Time | Recommended Timeout |
+|---------|---------------|-------------------|
+| `pnpm install --frozen-lockfile` | 3-4 minutes | 10+ minutes |
+| `pnpm run lint` | 1-2 minutes | 5+ minutes |
+| `pnpm run check` | 3-4 minutes | 8+ minutes |
+| `pnpm test:kit` | 10-15 minutes | 30+ minutes |
+| `pnpm test:others` | 2-3 minutes | 10+ minutes |
+| `pnpm run format` | ~15 seconds | 2+ minutes |
+| `pnpm build` | 1-2 seconds | 2+ minutes |
+| Dev server startup | 1-2 seconds | 1+ minute |
+| Unit tests | ~6 seconds | 2+ minutes |
+
+## Troubleshooting
+
+### Browser Tests Fail
+- Install Playwright browsers: `pnpm playwright install chromium`
+- For full browser support: `pnpm playwright install`
+
+### Build Failures
+- Ensure all dependencies installed: `pnpm install --frozen-lockfile`
+- Regenerate types: `cd packages/kit && pnpm prepublishOnly`
+- Check for TypeScript errors: `pnpm run check`
+
+### Lint/Format Issues
+- Auto-fix formatting: `pnpm run format`
+- Check specific package: `cd packages/[name] && pnpm lint`
+
+### Development Server Issues
+- Ensure sync is complete: `pnpm run sync-all`
+- Check for port conflicts (default: 5173)
+- Restart with clean cache: Clear node_modules and reinstall
+
+## Git Hooks
+Configure git hooks for automatic validation:
+```bash
+git config core.hookspath .githooks
+```
+
+## Output Examples
+
+### Successful pnpm install completion:
+```
+Done in 2m 48.5s using pnpm v10.14.0
+```
+
+### Successful dev server startup:
+```
+VITE v6.3.5  ready in 1145 ms
+➜  Local:   http://localhost:5173/
+```
+
+### CLI help output:
+```
+Usage
+  $ svelte-kit <command> [options]
+
+Available Commands
+  sync    Synchronise generated type definitions
+```

.eslint/no-runtime-to-exports-imports.js

@@ -17,9 +17,9 @@ jobs:
     if: github.repository == 'sveltejs/kit'
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: pnpm/[email protected]
-      - uses: actions/setup-node@v4
+      - uses: actions/setup-node@v5
         with:
           node-version: '22.x'
           cache: pnpm

.github/copilot-instructions.md

@@ -22,9 +22,9 @@ jobs:
   pkg-pr-new:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: pnpm/[email protected]
-      - uses: actions/setup-node@v4
+      - uses: actions/setup-node@v5
         with:
           node-version: 22
           cache: pnpm
@@ -34,9 +34,9 @@ jobs:
   lint-all:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: pnpm/[email protected]
-      - uses: actions/setup-node@v4
+      - uses: actions/setup-node@v5
         with:
           node-version: 22
           cache: pnpm
@@ -64,9 +64,9 @@ jobs:
       KIT_E2E_BROWSER: ${{matrix.e2e-browser}}
     steps:
       - run: git config --global core.autocrlf false
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: pnpm/[email protected]
-      - uses: actions/setup-node@v4
+      - uses: actions/setup-node@v5
         with:
           node-version: ${{ matrix.node-version }}
           cache: pnpm
@@ -124,9 +124,9 @@ jobs:
       KIT_E2E_BROWSER: ${{matrix.e2e-browser}}
     steps:
       - run: git config --global core.autocrlf false
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: pnpm/[email protected]
-      - uses: actions/setup-node@v4
+      - uses: actions/setup-node@v5
         with:
           node-version: ${{ matrix.node-version }}
           cache: pnpm
@@ -158,9 +158,9 @@ jobs:
           - mode: 'build'
     steps:
       - run: git config --global core.autocrlf false
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: pnpm/[email protected]
-      - uses: actions/setup-node@v4
+      - uses: actions/setup-node@v5
         with:
           node-version: 22
           cache: pnpm
@@ -187,9 +187,9 @@ jobs:
       matrix:
         node-version: [18, 20, 22, 24]
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
       - uses: pnpm/[email protected]
-      - uses: actions/setup-node@v4
+      - uses: actions/setup-node@v5
         with:
           node-version: ${{matrix.node-version}}
           cache: pnpm

.github/workflows/audit.yml

@@ -18,15 +18,15 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout Repo
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
         with:
           # This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits
           fetch-depth: 0
       - uses: pnpm/[email protected]
       - name: Setup Node.js
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@v5
         with:
-          node-version: 22.x
+          node-version: 24.x
           cache: pnpm
 
       - run: pnpm install --frozen-lockfile
@@ -41,7 +41,6 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           NPM_CONFIG_PROVENANCE: true
-          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
 
       # TODO alert discord
       # - name: Send a Slack notification if a publish happens