fix(cli): avoid printing duplicated --no-install flag (#803)

* fix(cli): display agrs with no duplicates

* simple

* fix also the [path]

* bring back default to local place

* don't use absolute path

* better changeset

---------

Co-authored-by: Manuel Serret <[email protected]>

Author: jycouet

.changeset/ripe-hoops-leave.md

@@ -0,0 +1,5 @@
+---
+'sv': patch
+---
+
+fix(cli): avoid printing duplicated `--no-install` flag

documentation/docs/20-commands/10-sv-create.md

@@ -48,7 +48,7 @@ Add add-ons to the project in the `create` command. Following the same format as
 Example:
 
 ```sh
-npx sv create --add eslint prettier
+npx sv create --add eslint prettier [path]
 ```
 
 ### `--no-add-ons`

packages/cli/commands/add/index.ts

@@ -184,7 +184,7 @@ export const add = new Command('add')
 				options,
 				selectedAddons,
 				workspace,
-				withLogArgs: true
+				fromCommand: 'add'
 			});
 
 			if (nextSteps.length > 0) {
@@ -547,15 +547,15 @@ export async function runAddonsApply({
 	selectedAddons,
 	addonSetupResults,
 	workspace,
-	withLogArgs
+	fromCommand
 }: {
 	answersOfficial: Record<string, OptionValues<any>>;
 	answersCommunity: Record<string, OptionValues<any>>;
 	options: Options;
 	selectedAddons: SelectedAddon[];
 	addonSetupResults?: Record<string, AddonSetupResult>;
 	workspace: Workspace;
-	withLogArgs?: boolean;
+	fromCommand: 'create' | 'add';
 }): Promise<{ nextSteps: string[]; argsFormattedAddons: string[] }> {
 	if (!addonSetupResults) {
 		const setups = selectedAddons.length
@@ -657,11 +657,7 @@ export async function runAddonsApply({
 		}
 	}
 
-	if (packageManager === null || packageManager === undefined)
-		argsFormattedAddons.push('--no-install');
-	else argsFormattedAddons.push('--install', packageManager);
-
-	if (withLogArgs) common.logArgs(packageManager ?? 'npm', 'add', argsFormattedAddons);
+	if (fromCommand === 'add') common.logArgs(packageManager, 'add', argsFormattedAddons);
 
 	if (packageManager) {
 		workspace.packageManager = packageManager;

packages/cli/commands/create.ts

@@ -281,7 +281,8 @@ async function createProject(cwd: ProjectPath, options: Options) {
 			},
 			selectedAddons,
 			addonSetupResults: undefined,
-			workspace
+			workspace,
+			fromCommand: 'create'
 		});
 		argsFormattedAddons = argsFormatted;
 
@@ -296,7 +297,7 @@ async function createProject(cwd: ProjectPath, options: Options) {
 				: options.install;
 
 	// Build args for next time based on non-default options
-	const argsFormatted = [cwd ?? defaultPath];
+	const argsFormatted: string[] = [];
 
 	argsFormatted.push('--template', template);
 
@@ -306,10 +307,7 @@ async function createProject(cwd: ProjectPath, options: Options) {
 
 	if (argsFormattedAddons.length > 0) argsFormatted.push('--add', ...argsFormattedAddons);
 
-	if (packageManager === null || packageManager === undefined) argsFormatted.push('--no-install');
-	else argsFormatted.push('--install', packageManager);
-
-	common.logArgs(packageManager ?? 'npm', 'create', argsFormatted);
+	common.logArgs(packageManager, 'create', argsFormatted, [cwd ?? defaultPath]);
 
 	await addPnpmBuildDependencies(projectPath, packageManager, ['esbuild']);
 	if (packageManager) await installDependencies(packageManager, projectPath);

packages/cli/utils/common.ts

@@ -137,11 +137,20 @@ export function parseAddonOptions(optionFlags: string | undefined): string[] | u
 	return options;
 }
 
-export function logArgs(agent: AgentName, actionName: string, args: string[]) {
-	const defaultArgs = ['sv', actionName, ...args];
-	const res = resolveCommand(agent, 'execute', defaultArgs);
-	if (res) p.log.message(pc.dim([res.command, ...res.args].join(' ')));
-	else p.log.message(pc.dim([`npx`, ...defaultArgs].join(' ')));
+export function logArgs(
+	agent: AgentName | null | undefined,
+	command: 'create' | 'add',
+	args: string[],
+	lastArgs: string[] = []
+) {
+	const allArgs = ['sv', command, ...args];
+
+	// Handle install option
+	if (agent === null || agent === undefined) allArgs.push('--no-install');
+	else allArgs.push('--install', agent);
+
+	const res = resolveCommand(agent ?? 'npm', 'execute', [...allArgs, ...lastArgs])!;
+	p.log.message(pc.dim([res.command, ...res.args].join(' ')));
 }
 
 export function errorAndExit(message: string) {