Skip to content

Commit ce6a297

Browse files
committed
feat(cli): wrap links with resolve()
1 parent f398f7f commit ce6a297

File tree

4 files changed

+17
-6
lines changed

4 files changed

+17
-6
lines changed

.changeset/free-bats-march.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'sv': patch
3+
---
4+
5+
feat(cli): wrap links with `resolve()` function to follow [best practices](https://svelte.dev/docs/kit/$app-paths#resolve)

packages/create/templates/demo/src/routes/Header.svelte

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<script lang="ts">
2+
import { resolve } from '$app/paths';
23
import { page } from '$app/state';
34
import logo from '$lib/images/svelte-logo.svg';
45
import github from '$lib/images/github.svg';
@@ -17,13 +18,13 @@
1718
</svg>
1819
<ul>
1920
<li aria-current={page.url.pathname === '/' ? 'page' : undefined}>
20-
<a href="/">Home</a>
21+
<a href={resolve('/')}>Home</a>
2122
</li>
2223
<li aria-current={page.url.pathname === '/about' ? 'page' : undefined}>
23-
<a href="/about">About</a>
24+
<a href={resolve('/about')}>About</a>
2425
</li>
2526
<li aria-current={page.url.pathname.startsWith('/sverdle') ? 'page' : undefined}>
26-
<a href="/sverdle">Sverdle</a>
27+
<a href={resolve('/sverdle')}>Sverdle</a>
2728
</li>
2829
</ul>
2930
<svg viewBox="0 0 2 3" aria-hidden="true">

packages/create/templates/demo/src/routes/about/+page.svelte

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
<script lang="ts">
2+
import { resolve } from '$app/paths';
3+
</script>
4+
15
<svelte:head>
26
<title>About</title>
37
<meta name="description" content="About this app" />
@@ -20,7 +24,7 @@
2024
</p>
2125

2226
<p>
23-
The <a href="/sverdle">Sverdle</a> page illustrates SvelteKit's data loading and form handling. Try
24-
using it with JavaScript disabled!
27+
The <a href={resolve('/sverdle')}>Sverdle</a> page illustrates SvelteKit's data loading and form
28+
handling. Try using it with JavaScript disabled!
2529
</p>
2630
</div>

packages/create/templates/demo/src/routes/sverdle/+page.svelte

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<script lang="ts">
22
import { enhance } from '$app/forms';
3+
import { resolve } from '$app/paths';
34
import { confetti } from '@neoconfetti/svelte';
45
import type { ActionData, PageData } from './$types';
56
import { MediaQuery } from 'svelte/reactivity';
@@ -117,7 +118,7 @@
117118
};
118119
}}
119120
>
120-
<a class="how-to-play" href="/sverdle/how-to-play">How to play</a>
121+
<a class="how-to-play" href={resolve('/sverdle/how-to-play')}>How to play</a>
121122

122123
<div class="grid" class:playing={!won} class:bad-guess={form?.badGuess}>
123124
{#each Array.from(Array(6).keys()) as row (row)}

0 commit comments

Comments
 (0)