Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsdeliver #49

Merged
merged 3 commits into from
Aug 22, 2016
Merged

Jsdeliver #49

merged 3 commits into from
Aug 22, 2016

Conversation

nicolashefti
Copy link
Contributor

Include the built library into the repository for further accessibility on CDN like jsdeliver.

@nicolashefti nicolashefti mentioned this pull request Aug 5, 2016
@nicolashefti
Copy link
Contributor Author

nicolashefti commented Aug 12, 2016

Hi @jalateras, any question/comment on the PR?

Would be great if you can tag this new version afterward (1.0.8). This way jsdeliver can autoupdate the library. For more information, see:

@jalateras
Copy link
Contributor

@nicolashefti I will look t it in the next couple of days

@jalateras
Copy link
Contributor

@nicolashefti

Getting the following errors on build

Hash: af0024a4e35c795119f2
Version: webpack 1.13.2
Time: 21ms

ERROR in Entry module not found: Error: Cannot resolve 'file' or 'directory' ./core in /Users/jima/stoic/workspace/formula.js
Hash: 396c152fa7f618115f27
Version: webpack 1.13.2
Time: 21ms

ERROR in Entry module not found: Error: Cannot resolve 'file' or 'directory' ./core in /Users/jima/stoic/workspace/formula.js
Hash: 8fa7816a6aaa9e6cfaf3
Version: webpack 1.13.2
Time: 20ms

ERROR in Entry module not found: Error: Cannot resolve 'file' or 'directory' ./core in /Users/jima/stoic/workspace/formula.js
Hash: b98499c009c2b1d613f9
Version: webpack 1.13.2
Time: 21ms

ERROR in Entry module not found: Error: Cannot resolve 'file' or 'directory' ./core in /Users/jima/stoic/workspace/formula.js

@jalateras
Copy link
Contributor

Looks like you may have forgotten to check core in. Is it JS file or library or .....

@nicolashefti
Copy link
Contributor Author

@jalateras, I renamed ./index.js to ./lib/core.js to avoid having JS files at the root of the repository. Then I just ran 'make test' which did not trigger any error...

That being said I rollbacked this change which is unrelevant for the current PR. The build is now working on my side.

@hmalphettes hmalphettes merged commit 8bbb206 into sutoiku:master Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants