append nested arrays with mergeWithRules

[noslouch]

Does append work with nested arrays?

const a = {
  module: {
    rules: [{
      test: /\.js$/,
      use: {
        loader: 'babel-loader',
        options: {
          plugins: ['@babel/plugin-proposal-class-properties']
        },
      }
    }]
  }
};

const b = {
  module: {
    rules: [{
      test: /\.js$/,
      use: {
        loader: 'babel-loader',
        options: {
          plugins: ['styled-components']
        }
      }
    }]
  }
};

const rules = {
  module: {
    rules: {
      test: 'match',
      use: {
        loader: 'match',
        options: {
          plugins: 'append'
        }
      }
    }
  }
};

mergeWithRules(rules)(a, b);
// result
{
  module: {
    rules: [{
      test: /\.js$/,
      use: {
        loader: 'babel-loader',
        options: {
          plugins: ['@babel/plugin-proposal-class-properties']
        },
      }
    }]
  }
};

// expected
{
  module: {
    rules: [{
      test: /\.js$/,
      use: {
        loader: 'babel-loader',
        options: {
          plugins: ['@babel/plugin-proposal-class-properties', 'styled-components']
        },
      }
    }]
  }
};

[bebraw]

I think I have to add a bit of logic to catch the nested append case. Thanks for the heads up.

[noslouch]

Appreciate it!

[G-Rath]

I just hit exactly this situation, which I was expecting to work fine based on the documentation of mergeWithRules in the README 😬

[mohd-akram]

Any update on this?

[bebraw]

No update. A PR would be very welcome.

…

On 3. Nov 2021, at 14.46, Mohamed Akram ***@***.***> wrote:  Any update on this? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[burhanuday]

This issue can be closed - #206