Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and fix replay #310

Merged
merged 7 commits into from
Sep 22, 2021
Merged

Update and fix replay #310

merged 7 commits into from
Sep 22, 2021

Conversation

Nyano1337
Copy link
Contributor

@Nyano1337 Nyano1337 commented Sep 21, 2021

Sometimes the bots bug when a player cuts a trigger/wall too close, and it has been bothering us for a long time:rage:
Also, this problem can be traced back to the time since cksurf use velocity and angle to store our replay
(pretty worse legacy:joy:)

some like #20 #98 point it out directly but no one solve.

This PR cost me a half day, and here's what i'm mainly doing

  • Replace the function with methodmap
  • Support the old replay version(0x01) while using the new version(0x02)
  • Write and load new replay based on position and angle😊😊😊
  • Delete useless(unused) sentences and improve something

I haven't done enough testing yet, may have bugs
but hope that there's something change since this pr 😣😣😣.

standard replay based on origin and angle
still little laggy, and still many thing to be optimize(the whole plugin)
This reverts commit 7c4683f.
Copy link
Contributor

@dPexxIAM dPexxIAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a big change, and a lot of communities will be happy about this! thank you.

code seems good, but like you said, testing needed

@Nyano1337 Nyano1337 changed the title Rewrite the whole REPLAY Update and fix replay Sep 21, 2021
@1zc
Copy link
Member

1zc commented Sep 22, 2021

Did some testing:

  • Tested with some older broken replays we had in GFL, and they now work as expected with your PR!
  • Old replays work fine with the new version, didn't encounter any potential compatibility issues,
  • In an effort to break it, I also tested writing ridiculous replays of me just purposely clipping platforms as close as I could. Moved in stupid random ways & reset several times but could not break it,

Great work! Excited to see these issues finally be a thing of the past.

Copy link
Contributor

@dPexxIAM dPexxIAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

epic

@dPexxIAM dPexxIAM merged commit 4318cbe into surftimer:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants