Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another fix for Trigger OnEndTouch issue that keeping velocity when using teleport command #298

Merged
merged 8 commits into from
Sep 10, 2021

Conversation

Nyano1337
Copy link
Contributor

@Nyano1337 Nyano1337 commented Sep 9, 2021

not 100% fix if someone set their startzone inside a map trigger OnEndTouch boost zone
thanks dpexx's idea

Copy link
Contributor

@dPexxIAM dPexxIAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like this fix isn't doing anything different that what i PR'd, other that changing variable names and calling them slightly different. unless i'm wrong..

Any reason why you set g_bTeleByCommand[client] = true; in each commands function rather than just calling it inside TeleportClient?

@Nyano1337
Copy link
Contributor Author

Nyano1337 commented Sep 10, 2021

just imaging ur standing on a big ground that full of endtouch trigger, and u cannot back to the start zone by command directly

i am not sure whether TeleportClient function will be only used by command or not in the future

@dPexxIAM
Copy link
Contributor

Did you test your code? When I implemented it, it seemed to just nuke the output of the trigger entirely.

just imaging ur standing on a big ground that full of endtouch trigger, and u cannot back to the start zone by command directly

i am not sure whether TeleportClient function will be only used by command or not in the future

This shouldn't cause that many issues but i can agree it isn't ideal.

You should use TeleportClient instead.

Copy link
Contributor

@dPexxIAM dPexxIAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!!

@dPexxIAM dPexxIAM merged commit fa14bef into surftimer:master Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants