Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify style = 0 when running db_selectPlayerRank #292

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Specify style = 0 when running db_selectPlayerRank #292

merged 1 commit into from
Sep 7, 2021

Conversation

1zc
Copy link
Member

@1zc 1zc commented Sep 5, 2021

This is a tiny modification to the queries used in the db_selectPlayerRank function. When players use the /rank @# command to check someone's rank and points in the chat, the db_selectPlayerRank can display style ranks and points, often leading to confusion.

A good example of this can be seen in the screenshots below. The first screenshot showcases the /rank @1 command before this fix - the expected result should be "w", but we instead see Dini's slow motion top rank and score.
image

With this fix, issuing the same command gives us the expected results:
image

Copy link
Member

@Bara Bara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

atm. I'm fine with it. I keep this open for another opinion.

@dPexxIAM dPexxIAM merged commit 5464877 into surftimer:master Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants