Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute selector completion #20

Closed
chenasraf opened this issue Feb 10, 2016 · 3 comments
Closed

Attribute selector completion #20

chenasraf opened this issue Feb 10, 2016 · 3 comments

Comments

@chenasraf
Copy link

I remember using JetBrains products, and there you could do something like this:

input[type=checkbox][placeholder=test]TAB

Which would complete to:

<input type="checkbox" placeholder="test" />

I think it could be really useful here.

@surdu
Copy link
Owner

surdu commented Feb 10, 2016

Hello,

Thank you for your suggestion, but it was previously addressed here: #5 (comment)

@surdu surdu closed this as completed Feb 10, 2016
@chenasraf
Copy link
Author

If I developed this would you be reluctant to merge? Because I think it's particularly useful since:

  • We place the cursor inside the tag and not in the attributes so this causes you to do extra moving around
  • It shouldn't degrade the regular experience only add to it if one wants
  • It would make it easier to copy/paste CSS and use it directly

@surdu
Copy link
Owner

surdu commented Feb 11, 2016

Moving the cursor in the attribute region for block elements is already planned (#16).

It does not degrade the regular experience of users, but comparing the fact that the code has to be maintained and future-supported with the fact that it doesn't add much value it makes me reluctant to add it to the extension, sorry :( .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants